Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define -webkit-text-stroke sub-properties #232

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

cdoublev
Copy link
Contributor

@cdoublev cdoublev commented Feb 7, 2023

This an editorial change.

The property is a shorthand for ... is a canonical sentence often used in CSS specs, which is followed by the names of its sub-properties, therefore the current text is ambiguous because it links to the SVG 2 spec and suggests that this spec defines its sub-properties.


Preview | Diff

Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cdoublev

@karlcow
Copy link
Member

karlcow commented Feb 9, 2023

hmm why the build is failing.

Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdoublev

shorthand property

could you remove the trailing whitespace after property?

@cdoublev
Copy link
Contributor Author

cdoublev commented Feb 9, 2023

Fixed but I suspect that curl is now failing to request resources.whatwg.org in the deploy script.

@karlcow
Copy link
Member

karlcow commented Feb 9, 2023

🤯 what?! fun time.

Error running preprocessor, returned code: 2.
LINK ERROR: Multiple possible 'stroke' dfn refs.
Arbitrarily chose https://svgwg.org/specs/strokes/#StrokeProperty
To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
spec:svg-strokes; type:dfn; text:stroke
spec:svg2; type:dfn; text:stroke
[=stroke=]
make: *** [Makefile:23: deploy] Error 22
 ✘  Did not generate, due to fatal errors

@karlcow
Copy link
Member

karlcow commented Feb 9, 2023

@miketaylr @annevk do you know what is happening with bikeshed here?

@annevk
Copy link
Member

annevk commented Feb 9, 2023

There's two definitions of stoke and you need to pick one. Presumably you would also get this error on main. What that means is that since you last ran CI the set of definitions Reffy picks up on has changed.

You might also want to file an issue against SVG telling them they shouldn't do stuff like this.

@cdoublev
Copy link
Contributor Author

cdoublev commented Feb 9, 2023

I do not think link errors are fatal. It even fails only with the metadata headers using https://api.csswg.org/bikeshed/.

@annevk
Copy link
Member

annevk commented Feb 9, 2023

We intentionally configured WHATWG CI to make all warnings and errors fatal. (Bikeshed has a force mode, but we consider that bad practice.)

@miketaylr
Copy link
Member

@cdoublev you'll want to do something like so:

diff --git a/compatibility.bs b/compatibility.bs
index 6911c2b..950796f 100644
--- a/compatibility.bs
+++ b/compatibility.bs
@@ -62,6 +62,7 @@
 spec:filter-effects-1; type:property; text:filter
 spec:infra; type:dfn; text:user agent
 spec:svg2; type:dfn; text:fill
+spec:svg2; type:dfn; text:stroke
 </pre>
 
 <!-- Commented out until we know what the heck to put here:

(or you can select "Allow edits from maintainers." and I can push it).

@cdoublev
Copy link
Contributor Author

Do you think the error now comes from the link on invalid?

Allow edits by maintainers is already checked, but feel free to reproduce my edit in a separate PR.

@miketaylr
Copy link
Member

Allow edits by maintainers is already checked, but feel free to reproduce my edit in a separate PR.

Ah cool, I was on an airplane last night when I wrote that, and every other request was failing - could have just been that.

@miketaylr
Copy link
Member

Do you think the error now comes from the link on invalid?

Yep, sigh... w3c/rdf-semantics@af9fc78

Can you add spec:css-syntax-3; type:dfn; text:invalid as well?

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay in getting this landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants