-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define -webkit-text-stroke sub-properties #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cdoublev
hmm why the build is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed but I suspect that |
🤯 what?! fun time.
|
@miketaylr @annevk do you know what is happening with bikeshed here? |
There's two definitions of stoke and you need to pick one. Presumably you would also get this error on main. What that means is that since you last ran CI the set of definitions Reffy picks up on has changed. You might also want to file an issue against SVG telling them they shouldn't do stuff like this. |
I do not think link errors are fatal. It even fails only with the metadata headers using https://api.csswg.org/bikeshed/. |
We intentionally configured WHATWG CI to make all warnings and errors fatal. (Bikeshed has a force mode, but we consider that bad practice.) |
@cdoublev you'll want to do something like so: diff --git a/compatibility.bs b/compatibility.bs
index 6911c2b..950796f 100644
--- a/compatibility.bs
+++ b/compatibility.bs
@@ -62,6 +62,7 @@
spec:filter-effects-1; type:property; text:filter
spec:infra; type:dfn; text:user agent
spec:svg2; type:dfn; text:fill
+spec:svg2; type:dfn; text:stroke
</pre>
<!-- Commented out until we know what the heck to put here: (or you can select "Allow edits from maintainers." and I can push it). |
Do you think the error now comes from the link on
|
Ah cool, I was on an airplane last night when I wrote that, and every other request was failing - could have just been that. |
Yep, sigh... w3c/rdf-semantics@af9fc78 Can you add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry for the delay in getting this landed.
This an editorial change.
The property is a shorthand for ... is a canonical sentence often used in CSS specs, which is followed by the names of its sub-properties, therefore the current text is ambiguous because it links to the SVG 2 spec and suggests that this spec defines its sub-properties.
Preview | Diff