Export terms needed for ServiceWorker/1674 #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakearchibald
changed the title
|
That sounds preferable. Preferably with a "legacy" prefix to prevent copycats. "legacy-obtain service-worker fetch event listeners" or some such that takes a service worker global and returns that subset of listeners. |
|
@annevk done! PTAL |
annevk
reviewed
Mar 20, 2023
dom.bs
Outdated
| @@ -1243,6 +1243,25 @@ property of the event being dispatched. | |||
| <p>Ideally, any new event APIs are defined such that they do not need this property. (Use | |||
| <a href="https://github.com/whatwg/dom/issues">whatwg/dom</a> for discussion.) | |||
|
|
|||
| <p>To <dfn export>legacy-obtain service worker fetch event listeners</dfn> given a | |||
dom.bs
Outdated
| {{EventListener}} objects. | ||
|
|
||
| <ol> | ||
| <li><p>Let <var>eventListeners</var> be a new <a for=/>list</a>. |
There was a problem hiding this comment.
Suggested change
| <li><p>Let <var>eventListeners</var> be a new <a for=/>list</a>. | |
| <li><p>Let <var>callbacks</var> be « ». |
|
@annevk feedback addressed! |
|
@annevk happy to land this? |
jakearchibald
commented
Mar 22, 2023
annevk
force-pushed
the
jakearchibald/export-event-terms
branch
from
f23deea
to
1b8bfc4
Compare
|
Thanks @jakearchibald! |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exports the terms needed for w3c/ServiceWorker#1672 (now w3c/ServiceWorker#1674).
However, this includes exporting a term that was marked "Intentionally not exported". Soooooo, what now @annevk? 😄
We need to be able to look at the listeners to determine they're all no-op. I could add an algorithm to the DOM spec that gets the listeners of type "fetch" for a given service worker global. That would avoid exporting the whole concept. In fact, we wouldn't seen the other exports either in that case.
Preview | Diff