Add AbortSignal.aborted() static #960

jasnell · 2021-03-09T18:58:08Z

Returns an already aborted AbortSignal per #959

Fixes: #959

At least two implementers are interested (and none opposed):
- Node.js
- Mozilla
- Chromium
Tests are written and can be reviewed and commented upon at:
- Add test for proposed AbortSignal.abort() web-platform-tests/wpt#28003
Implementation bugs are filed:
- Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1187117
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1698468
- Safari: https://bugs.webkit.org/show_bug.cgi?id=223071

(See WHATWG Working Mode: Changes for more details.)

annevk

This looks great, thanks for working on this James!

@josepharhar @smaug---- @mfreed7 @rniwa thoughts on adding this? Seems simple enough and there's precedent with promises (Promise.reject()). Though maybe that means this should be AbortSignal.abort()?

dom.bs

Proposed new API addition. Refs: whatwg/dom#960

jasnell · 2021-03-10T16:28:45Z

PR to add test here: web-platform-tests/wpt#28003
PR to add impl to Node.js: nodejs/node#37693

Refs: whatwg/dom#960

annevk

Thanks, this looks good to me. Mozilla would be fine with adding this.

dom.bs

Returns an already aborted AbortSignal

Refs: whatwg/dom#960

josepharhar · 2021-03-11T15:38:31Z

lgtm, this looks particularly easy to implement :)

annevk · 2021-03-11T15:54:31Z

@jasnell thanks! You or your employer will need to sign https://participate.whatwg.org/agreement to appease the IPR bot.

It seems we're all done here apart from that. @benjamingr @jakearchibald @domenic @MattiasBuelens any final thoughts?

jasnell · 2021-03-11T15:56:24Z

You or your employer will need to sign participate.whatwg.org/agreement to appease the IPR bot.

Done!

domenic · 2021-03-11T15:56:31Z

LGTM. I still vaguely prefer the aborted() name but I can bow to the consistency argument with Promise.reject() and Promise.resolve().

benjamingr · 2021-03-11T16:12:25Z

This generally looks fine to me and makes sense, though bike-shedding, I'm not sure I like the name.

mfreed7 · 2021-03-11T17:31:12Z

lgtm, this looks particularly easy to implement :)

rsLGTM based on @josepharhar's LGTM. Thanks!

annevk · 2021-03-12T08:52:28Z

@jasnell do you want to file the bug against Firefox?

See whatwg/dom#960.

dom.bs

jasnell · 2021-03-12T12:37:07Z

Yeah I'll do so this morning!

annevk · 2021-03-15T11:23:17Z

I ended up filing https://bugzilla.mozilla.org/show_bug.cgi?id=1698468.

Thanks everyone for the quick turnaround! Hopefully it'll get implemented in a similar pace. 😊

jasnell · 2021-03-15T12:31:47Z

Thanks @annevk ... Sorry I had missed my reminder notification to do that! I appreciate it!

Refs: whatwg/dom#960 PR-URL: #37693 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Signed-off-by: James M Snell <[email protected]> PR-URL: #37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Refs: whatwg/dom#960 PR-URL: #37693 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Signed-off-by: James M Snell <[email protected]> PR-URL: #37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Refs: whatwg/dom#960 PR-URL: #37693 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Signed-off-by: James M Snell <[email protected]> PR-URL: #37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

benjamingr · 2021-03-17T12:13:40Z

Does this need an "impacts documentation" label?

annevk · 2021-03-17T12:17:08Z

cc @whatwg/documentation

sideshowbarker · 2021-03-18T04:59:46Z

I’ll make time to write up MDN documentation for this some time this month (unless somebody gets to it before I manage to)

Refs: whatwg/dom#960

PR-URL: nodejs#37798 Refs: whatwg/dom#960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>

https://bugs.webkit.org/show_bug.cgi?id=223071 <rdar://problem/75575483> Reviewed by Darin Adler. LayoutTests/imported/w3c: Resync WPT test from upstream a8cbe9c to gain test coverage. * web-platform-tests/dom/abort/event.any-expected.txt: * web-platform-tests/dom/abort/event.any.js: * web-platform-tests/dom/abort/event.any.worker-expected.txt: Source/WebCore: Implement AbortSignal.abort() which creates and returns an already aborted AbortSignal: - whatwg/dom#960 - web-platform-tests/wpt#28003 No new tests, covered by updated test. * dom/AbortSignal.cpp: (WebCore::AbortSignal::createAborted): (WebCore::AbortSignal::AbortSignal): * dom/AbortSignal.h: * dom/AbortSignal.idl: Canonical link: https://commits.webkit.org/235582@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@274773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PR-URL: #37798 Refs: whatwg/dom#960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>

https://bugs.webkit.org/show_bug.cgi?id=223071 <rdar://problem/75575483> Reviewed by Darin Adler. LayoutTests/imported/w3c: Resync WPT test from upstream a8cbe9c712ad032d36 to gain test coverage. * web-platform-tests/dom/abort/event.any-expected.txt: * web-platform-tests/dom/abort/event.any.js: * web-platform-tests/dom/abort/event.any.worker-expected.txt: Source/WebCore: Implement AbortSignal.abort() which creates and returns an already aborted AbortSignal: - whatwg/dom#960 - web-platform-tests/wpt#28003 No new tests, covered by updated test. * dom/AbortSignal.cpp: (WebCore::AbortSignal::createAborted): (WebCore::AbortSignal::AbortSignal): * dom/AbortSignal.h: * dom/AbortSignal.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@274773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Refs: whatwg/dom#960 PR-URL: nodejs#37693 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Signed-off-by: James M Snell <[email protected]> PR-URL: nodejs#37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Refs: whatwg/dom#960 PR-URL: nodejs#37693 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Signed-off-by: James M Snell <[email protected]> PR-URL: nodejs#37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Refs: whatwg/dom#960 PR-URL: nodejs#37693 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Signed-off-by: James M Snell <[email protected]> PR-URL: nodejs#37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Refs: whatwg/dom#960 PR-URL: #37693 Backport-PR-URL: #38386 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Signed-off-by: James M Snell <[email protected]> PR-URL: #37693 Backport-PR-URL: #38386 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

annevk reviewed Mar 10, 2021

View reviewed changes

dom.bs Outdated Show resolved Hide resolved

dom.bs Outdated Show resolved Hide resolved

dom.bs Outdated Show resolved Hide resolved

annevk added the needs tests Moving the issue forward requires someone to write tests label Mar 10, 2021

jasnell force-pushed the abortsignal-aborted-static branch 2 times, most recently from 0559b7a to 089887c Compare March 10, 2021 16:16

jasnell added a commit to jasnell/wpt that referenced this pull request Mar 10, 2021

Add test for proposed AbortSignal.abort()

e5ebd31

Proposed new API addition. Refs: whatwg/dom#960

jasnell mentioned this pull request Mar 10, 2021

Add test for proposed AbortSignal.abort() web-platform-tests/wpt#28003

Merged

jasnell added a commit to jasnell/node that referenced this pull request Mar 10, 2021

lib: implement AbortSignal.abort()

cfb02a0

Refs: whatwg/dom#960

jasnell mentioned this pull request Mar 10, 2021

lib: implement AbortSignal.abort() nodejs/node#37693

Closed

annevk reviewed Mar 11, 2021

View reviewed changes

dom.bs Outdated Show resolved Hide resolved

dom.bs Outdated Show resolved Hide resolved

annevk added needs implementer interest Moving the issue forward requires implementers to express interest and removed needs tests Moving the issue forward requires someone to write tests labels Mar 11, 2021

jasnell added 2 commits March 11, 2021 07:09

Add AbortSignal.aborted() static

69b9e88

Returns an already aborted AbortSignal

Add myself to Acknolwedgements

7ed2987

jasnell force-pushed the abortsignal-aborted-static branch from 089887c to 7ed2987 Compare March 11, 2021 15:09

jasnell added a commit to jasnell/node that referenced this pull request Mar 11, 2021

lib: implement AbortSignal.abort()

0b60272

Refs: whatwg/dom#960

annevk added topic: aborting AbortController and AbortSignal and removed needs implementer interest Moving the issue forward requires implementers to express interest labels Mar 12, 2021

annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 12, 2021

Add test for AbortSignal.abort()

1728d19

See whatwg/dom#960.

annevk reviewed Mar 12, 2021

View reviewed changes

dom.bs Show resolved Hide resolved

Update dom.bs

9f6ba3c

annevk reviewed Mar 12, 2021

View reviewed changes

dom.bs Outdated Show resolved Hide resolved

Update dom.bs

ad33d53

sigh

82f0e6c

annevk merged commit aa384af into whatwg:main Mar 12, 2021

annevk added the impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation label Mar 17, 2021

manekinekko added a commit to manekinekko/node that referenced this pull request Mar 18, 2021

test: refactor code to use AbortSignal.abort()

a800c41

Refs: whatwg/dom#960

manekinekko added a commit to manekinekko/node that referenced this pull request Mar 18, 2021

test: refactor code to use AbortSignal.abort()

722516a

Refs: whatwg/dom#960

manekinekko mentioned this pull request Mar 18, 2021

test: refactor code to use AbortSignal.abort() nodejs/node#37798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AbortSignal.aborted() static #960

Add AbortSignal.aborted() static #960

jasnell commented Mar 9, 2021 •

edited by annevk

Loading

annevk left a comment

jasnell commented Mar 10, 2021 •

edited

Loading

annevk left a comment

josepharhar commented Mar 11, 2021

annevk commented Mar 11, 2021

jasnell commented Mar 11, 2021

domenic commented Mar 11, 2021

benjamingr commented Mar 11, 2021

mfreed7 commented Mar 11, 2021

annevk commented Mar 12, 2021

jasnell commented Mar 12, 2021

annevk commented Mar 15, 2021

jasnell commented Mar 15, 2021 •

edited

Loading

benjamingr commented Mar 17, 2021

annevk commented Mar 17, 2021

sideshowbarker commented Mar 18, 2021 •

edited

Loading

Add AbortSignal.aborted() static #960

Add AbortSignal.aborted() static #960

Conversation

jasnell commented Mar 9, 2021 • edited by annevk Loading

annevk left a comment

Choose a reason for hiding this comment

jasnell commented Mar 10, 2021 • edited Loading

annevk left a comment

Choose a reason for hiding this comment

josepharhar commented Mar 11, 2021

annevk commented Mar 11, 2021

jasnell commented Mar 11, 2021

domenic commented Mar 11, 2021

benjamingr commented Mar 11, 2021

mfreed7 commented Mar 11, 2021

annevk commented Mar 12, 2021

jasnell commented Mar 12, 2021

annevk commented Mar 15, 2021

jasnell commented Mar 15, 2021 • edited Loading

benjamingr commented Mar 17, 2021

annevk commented Mar 17, 2021

sideshowbarker commented Mar 18, 2021 • edited Loading

jasnell commented Mar 9, 2021 •

edited by annevk

Loading

jasnell commented Mar 10, 2021 •

edited

Loading

jasnell commented Mar 15, 2021 •

edited

Loading

sideshowbarker commented Mar 18, 2021 •

edited

Loading