Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point default referrer policy to a constant defined in RP spec #1066

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

krgovind
Copy link
Contributor

@krgovind krgovind commented Aug 3, 2020

This is a re-do of #952 started by @mikewest since I am taking over the relevant spec updates.

This spec will now point to a constant defined in w3c/webappsec-referrer-policy/pull/142 as the default referrer policy.


Preview | Diff

@annevk
Copy link
Member

annevk commented Aug 4, 2020

Thank you! You'll need to make your membership of the googlers organization public.

@krgovind
Copy link
Contributor Author

krgovind commented Aug 4, 2020

Thank you! You'll need to make your membership of the googlers organization public.

Done! It's my first time contributing to specs, so still discovering all the boxes I need to check off. :)

@annevk
Copy link
Member

annevk commented Aug 5, 2020

Great! (Landing this is blocked on w3c/webappsec-referrer-policy#142.)

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Aug 6, 2020
Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And as Anne said, I think we'll hold off on merging this until:

  • Referrer Policy spec changes lands
  • WPTs are ready to land

@krgovind
Copy link
Contributor Author

Great! (Landing this is blocked on w3c/webappsec-referrer-policy#142.)

w3c/webappsec-referrer-policy#142 has now landed. Could we merge this please?

@annevk
Copy link
Member

annevk commented Nov 30, 2020

From the Referrer Policy issue:

Is there a Safari bug? At least I got the impression they did not ship a strict superset of this.

@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Nov 30, 2020
@annevk annevk merged commit eda4152 into whatwg:master Nov 30, 2020
@krgovind
Copy link
Contributor Author

Safari bug is here.

@annevk
Copy link
Member

annevk commented Nov 30, 2020

Thanks @krgovind! Glad this is mostly wrapped up now. I rebased the HTML PR and hopefully @domenic will have time for that soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants