s/early-hint/early-hints/ #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The value is also already WPT tested to align with the Chromium implementation |
|
Both |
|
I believe so ( |
|
I filed #1563 to see if this can be improved overall. |
|
@noamr could you confirm? Thanks! |
Confirmed. |
|
@yoavweiss by the way, this is not considered an editorial change, but since this has test coverage I'm assuming implementations do this correctly (or have not implemented this yet) and as such skipping the checklist is hopefully okay this time around. |
|
SG, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editorial change so checklist not required:
As pointed out in w3c/resource-timing#364, there's a discrepancy between the initiator "early-hint" value in Fetch and the Chromium implementation. This aligns the spec to the implementation.
Preview | Diff