Add device-memory and network quality client hints to the list #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @yoavweiss @igrigorik |
|
This doesn't seem to ever set them in the request? Also, I think we should start by fixing the architecture for what's there now first. Otherwise it'd be rather hard to write tests and such. |
|
And also, thanks for your pull request! And please add your name to the Acknowledgments section (unless you don't want to). |
|
annevk: I am working on fixing the architecture in the spec, but that's taking a bit longer. I thought I would get this out first. Since my blink-dev i2s requires all this yak shaving anyways, I am not sure if the order is super critical? Please let me know. Thanks! |
|
@tarunban https://whatwg.org/working-mode#changes might help. We have a pretty high bar for changes these days. So apart from these additions, we'll also need tests and the tests need to be based on the specification. And at that point you need the infrastructure in place. |
10 tasks
yoavweiss
added a commit
to yoavweiss/fetch
that referenced
this pull request
Aug 21, 2018
This change aligns the processing of Client-Hints with the shipped Chromium implementation, by changing the following: * Clone the environment settings object's client-hints set to the request's client-hints set. * Apply CH processing to all requests, rather than only subresource requests. * Add processing of new CH headers, added in whatwg#725 It also renames "client-hints list" to "client-hints set", and changes it to be a set, to match related HTML spec changes.
yoavweiss
added a commit
to yoavweiss/fetch
that referenced
this pull request
Aug 21, 2018
This change aligns the processing of Client-Hints with the shipped Chromium implementation, by changing the following: * Clone the environment settings object's client-hints set to the request's client-hints set. * Apply CH processing to all requests, rather than only subresource requests. * Add processing of new CH headers, added in whatwg#725 * Remove `DPR` and `Viewport-Width` from headers that are sent by default for navigation requests. It also renames "client-hints list" to "client-hints set", and changes it to be a set, to match related HTML spec changes.
yoavweiss
added a commit
to yoavweiss/fetch
that referenced
this pull request
Aug 21, 2018
This change aligns the processing of Client-Hints with the shipped Chromium implementation, by changing the following: * Clone the environment settings object's client-hints set to the request's client-hints set. * Apply CH processing to all requests, rather than only subresource requests. * Add processing of new CH headers, added in whatwg#725 * Remove `DPR` and `Viewport-Width` from headers that are sent by default for navigation requests. It also renames "client-hints list" to "client-hints set", and changes it to be a set, to match related HTML spec changes.
annevk
added
topic: client hints
needs tests
yoavweiss
added a commit
to yoavweiss/fetch
that referenced
this pull request
Jan 17, 2019
This change aligns the processing of Client-Hints with the shipped Chromium implementation, by changing the following: * Clone the environment settings object's client-hints set to the request's client-hints set. * Apply CH processing to all requests, rather than only subresource requests. * Add processing of new CH headers, added in whatwg#725 * Remove `DPR` and `Viewport-Width` from headers that are sent by default for navigation requests. It also renames "client-hints list" to "client-hints set", and changes it to be a set, to match related HTML spec changes.
yoavweiss
added a commit
to yoavweiss/fetch
that referenced
this pull request
Feb 12, 2019
yoavweiss
added a commit
to yoavweiss/fetch
that referenced
this pull request
Mar 26, 2019
This change aligns the processing of Client-Hints with the shipped Chromium implementation, by changing the following: * Clone the environment settings object's client-hints set to the request's client-hints set. * Apply CH processing to all requests, rather than only subresource requests. * Add processing of new CH headers, added in whatwg#725 * Remove `DPR` and `Viewport-Width` from headers that are sent by default for navigation requests. It also renames "client-hints list" to "client-hints set", and changes it to be a set, to match related HTML spec changes.
yoavweiss
added a commit
to yoavweiss/fetch
that referenced
this pull request
Mar 26, 2019
|
Closing per 6a644c6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
annevk: please take a look. This is the first PR where the new client hints are added to the spec.
Preview | Diff