Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.close() incorrectly refers to incumbent global object's node navigable #10418

Closed
awesomekling opened this issue Jun 20, 2024 · 2 comments · Fixed by #10420
Closed

window.close() incorrectly refers to incumbent global object's node navigable #10418

awesomekling opened this issue Jun 20, 2024 · 2 comments · Fixed by #10420

Comments

@awesomekling
Copy link
Member

What is the issue with the HTML Standard?

Here: https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-window-close

One of the subconditions of step 7 is:

the incumbent global object's node navigable is allowed by sandboxing to navigate thisTraversable, given sourceSnapshotParams

But global objects don't have a node navigable. Nodes have a node navigable.

It's not clear to me which node is being implied here. The active document of the incumbent global object's browsing context perhaps? Could use clarification :)

@domenic
Copy link
Member

domenic commented Jun 20, 2024

The intention is the incumbent global object's navigable.

@domenic
Copy link
Member

domenic commented Jun 20, 2024

We can probably also use that definition to simplify step 2.

domenic added a commit that referenced this issue Jun 21, 2024
Also clean up the initial steps by using some convenience definitions.

Closes #10418. Note that this does not help with #1866.
domenic added a commit that referenced this issue Jun 21, 2024
Also clean up the initial steps by using some convenience definitions.

Closes #10418. Note that this does not help with #1866.
annevk pushed a commit that referenced this issue Jul 2, 2024
Also clean up the initial steps by using some convenience definitions.

Closes #10418. Note that this does not help with #1866.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants