Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox cannot be checked through a synthetic click event when not in a document #1893

Closed
annevk opened this issue Oct 13, 2016 · 3 comments

Comments

@annevk
Copy link
Member

annevk commented Oct 13, 2016

Found this while trying to write a test for whatwg/dom#325. As far as I can tell this is currently not covered by the specification. In particular this is about the "pre-click activation steps".

domenic pushed a commit that referenced this issue Oct 18, 2016
This aligns firing and dispatching of events with updated terminology in
the DOM Standard. Among the changes:

* A lot less usage of "default action" which isn't really a thing.
  Instead we make use of the return value of the fire and dispatch
  algorithms.
* Instead of saying things bubble or are cancelable we initialize the
  attributes as such.
* We no longer re-state defaults for isTrusted, bubbles, and cancelable,
  as that only leads to confusion when they are *not* re-stated.
* We now use the legacy target override flag rather than supplying a
  named argument.

This fixes #1713, but plenty of follow up issues remain:

* #805 for the remainder of "default action" usage
* #1394 for updating synthetic click events
* #1887 for removing "fire a simple event" usage
* #1893 for updating when checkboxes get checked
* #1900 for figuring out if event dispatch requires more hooks
* #1912 for revisiting isTrusted usage
* #1913 for updating synthetic mouse events
* #1922 for making more events composed
@annevk
Copy link
Member Author

annevk commented Oct 19, 2016

Fixing this depends on the refactoring happening in #1394. Tests should probably land for this as well.

@annevk
Copy link
Member Author

annevk commented Oct 21, 2016

Per testing I think this should be WONTFIX and Firefox should simply fix its behavior at some point.

annevk added a commit to web-platform-tests/wpt that referenced this issue Oct 24, 2016
Closes whatwg/html#1893 as it turns out
only Firefox was not following the specification for radio/checkbox,
even though it’s a little weird they behave differently from
`<form>`. But you know, it’s the web.
zcorpan pushed a commit to web-platform-tests/wpt that referenced this issue Oct 25, 2016
Closes whatwg/html#1893 as it turns out
only Firefox was not following the specification for radio/checkbox,
even though it’s a little weird they behave differently from
`<form>`. But you know, it’s the web.
@zcorpan
Copy link
Member

zcorpan commented Oct 25, 2016

alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
This aligns firing and dispatching of events with updated terminology in
the DOM Standard. Among the changes:

* A lot less usage of "default action" which isn't really a thing.
  Instead we make use of the return value of the fire and dispatch
  algorithms.
* Instead of saying things bubble or are cancelable we initialize the
  attributes as such.
* We no longer re-state defaults for isTrusted, bubbles, and cancelable,
  as that only leads to confusion when they are *not* re-stated.
* We now use the legacy target override flag rather than supplying a
  named argument.

This fixes whatwg#1713, but plenty of follow up issues remain:

* whatwg#805 for the remainder of "default action" usage
* whatwg#1394 for updating synthetic click events
* whatwg#1887 for removing "fire a simple event" usage
* whatwg#1893 for updating when checkboxes get checked
* whatwg#1900 for figuring out if event dispatch requires more hooks
* whatwg#1912 for revisiting isTrusted usage
* whatwg#1913 for updating synthetic mouse events
* whatwg#1922 for making more events composed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants