Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give HTMLAllCollection its own class #210

Closed
annevk opened this issue Sep 29, 2015 · 6 comments
Closed

Give HTMLAllCollection its own class #210

annevk opened this issue Sep 29, 2015 · 6 comments
Assignees
@domenic
Labels
good first issue Ideal for someone new to a WHATWG standard or software project normative change

Comments

@annevk
Copy link
Member

annevk commented Sep 29, 2015

In #203 we discovered it should probably not inherit from HTMLCollection. This is already the case in Gecko: http://mxr.mozilla.org/mozilla-central/source/dom/webidl/HTMLAllCollection.webidl.
@annevk annevk added normative change clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project labels Sep 29, 2015
@domenic
Copy link
Member

domenic commented Sep 29, 2015

Test case: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=3641

  • Gecko: Object
  • Blink: Object
  • WebKit: Object
  • Edge: HTMLCollection

/cc @DigiTec

@domenic domenic removed the clarification Standard could be clearer label Sep 29, 2015
@annevk
Copy link
Member Author

annevk commented Sep 29, 2015

@travisleithead likes this stuff too.

@travisleithead
Copy link
Member

We can un-inherit this object in Edge. :-)

@DigiTec
Copy link

DigiTec commented Sep 30, 2015

Awesome. File the bugs and let's make it so.

@domenic domenic self-assigned this Sep 30, 2015
domenic added a commit that referenced this issue Sep 30, 2015
@domenic
Fix #210: give HTMLAllCollection its own class
7264c90 
This better matches browsers, and avoids the confusing inheritance which only applies to half of the item() method.
domenic added a commit that referenced this issue Sep 30, 2015
@domenic
Fix #210: give HTMLAllCollection its own class
090f3e6 
This better matches browsers, and avoids the confusing inheritance which only applies to half of the item() method.
domenic added a commit that referenced this issue Sep 30, 2015
@domenic
Fix #210: give HTMLAllCollection its own class
1009d38 
This better matches browsers, and avoids the confusing inheritance which only applies to half of the item() method.
domenic added a commit that referenced this issue Sep 30, 2015
@domenic
Fix #210: give HTMLAllCollection its own class
149069e 
This better matches browsers, and avoids the confusing inheritance which only applies to half of the item() method.
domenic added a commit that referenced this issue Sep 30, 2015
@domenic
Fix #210: give HTMLAllCollection its own class
09e0e93 
This better matches browsers, and avoids the confusing inheritance which only applies to half of the item() method.
domenic added a commit that referenced this issue Sep 30, 2015
@domenic
Fix #210: give HTMLAllCollection its own class
308afc5 
This better matches browsers, and avoids the confusing inheritance which only applies to half of the item() method.
domenic added a commit that referenced this issue Sep 30, 2015
@domenic
Fix #210: give HTMLAllCollection its own class
7cf5492 
This better matches browsers, and avoids the confusing inheritance which only applies to half of the item() method.
@travisleithead
Copy link
Member

(Travis: for future reference, this is VSO4791036).

@domenic domenic closed this as completed in 4bade08 Oct 1, 2015
@foolip
Copy link
Member

foolip commented Oct 1, 2015

Awesome, now I can remove the FIXME to make it inherit from HTMLCollection in Blink :)

@DigiTec DigiTec mentioned this issue Mar 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
good first issue Ideal for someone new to a WHATWG standard or software project normative change
Milestone
No milestone
Development

No branches or pull requests
5 participants
@foolip @domenic @annevk @DigiTec @travisleithead