-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable fieldset/legend rendering magic with CSS #3912
Comments
Related issue which also discusses appearance: none, #2805 |
I see 22 resources in httparchive that set 'appearance' on fieldset or legend: https://gist.github.com/zcorpan/53efbbe20df21f10dbdd5e1368c790c4 I have not yet analyzed these. |
Of those 22, there's only one that actually has a
As far as I can tell, it wouldn't render differently if the fieldset was a div. |
First draft of a proposal at https://docs.google.com/document/d/1JM0YmKNRmhl1nEqcg_M_KlxBg_q7LIz9xgzmbrHp34o/edit?usp=sharing This would allow appearance: none on the fieldset to remove the BFC, the forced 'display', the legend association. It also allows appearance: none on the legend to remove the BFC, the forced 'display', shrink-wrapping, alignment (or not?), and the special placement. It would also allow authors to specify these styles on other elements. |
TODO explain what this does. Fixes #3912 (TODO more issues).
The above doc received some comments from @MatsPalmgren (thanks!). I will preserve those comments there, but have now changed sharing such that new comments are not accepted. I have made a pull request that supersedes the doc; comments welcome there. |
TODO explain what this does. Fixes #3912 (TODO more issues).
The PR for this is #4035 @MatsPalmgren @mstensho is there still interest in solving this issue? |
See #4035 (comment) - leaving this issue open to come up with a different way to opt out of fieldset/legend magic rendering rules. |
WebKit would be interested in solving this. |
Today I asked on Twitter
https://twitter.com/zcorpan/status/1028999908433571846
answers so far
(It's display: block by default. Sites change the display value (to inline-block, table...) and expect the magic legend rendering.)
appearance: none is what I thought about before writing the tweet, also. Since float and position:absolute/fixed on the legend disentangles the legend, I thought appearance: none would go on the legend, but I suppose it could go on the fieldset instead.
Any preference on the implementation side, if we are to do this? cc @bzbarsky
The text was updated successfully, but these errors were encountered: