Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making <link> never match :link / :visited, and make it not traversable. #4831

Closed
emilio opened this issue Aug 9, 2019 · 5 comments · Fixed by #6269
Closed

Consider making <link> never match :link / :visited, and make it not traversable. #4831

emilio opened this issue Aug 9, 2019 · 5 comments · Fixed by #6269
Labels

Comments

@emilio
Copy link
Contributor

emilio commented Aug 9, 2019

See: https://groups.google.com/d/msg/mozilla.dev.platform/1NP6oJzK6zg/uUq9bFLaAAAJ

Basically, should you be able to navigate away when a <link href=""> foo is forcibly displayed?

Interop here is all over the place. Chrome doesn't but everybody else does.

Relatedly, Firefox and Safari used to allow to style a <link> as :visited, but Chrome and Edge didn't. Safari changed behavior a bit ago, and we'd like to do the same at least.

But it'd be nice if we could just make <link> not able to navigate away to begin with / never match :link and such.

@domenic
Copy link
Member

domenic commented Aug 9, 2019

I'd be in favor of simplifying this. It seems that the spec changes would be:

If Gecko is actively interested in shipping such a change, and Chrome already does, that would be 2/3 browser engines, and so we could merge such a change into the spec. But it'd of course be ideal to align everyone, so, any thoughts from @cdumez or @rniwa on disallowing navigation of <link> elements in WebKit? The case under consideration is something like

<style>
  link {
    display: block;
  }
  link::before {
    content: "foo";
  }
</style>
<body>
<link href="https://example.com/">

@domenic domenic added removal/deprecation Removing or deprecating a feature topic: hyperlink labels Aug 9, 2019
@rniwa
Copy link

rniwa commented Aug 9, 2019

Asking internally at Apple about this.

@josepharhar
Copy link
Contributor

Asking internally at Apple about this.

@rniwa any updates on this?

@domenic
Copy link
Member

domenic commented Jan 6, 2021

Let me prepare a spec PR to make this concrete.

domenic added a commit that referenced this issue Jan 6, 2021
In particular, remove their activation behavior, stop them from matching
:link and :visited, and stop suggesting that they be focusable areas.

This also includes a slight expansion and rearrangement of the link
element's section to make it clearer what hyperlinks created by <link>
are meant for, contrasting them to <a> and <area> hyperlinks.

Closes #4831. Closes #2617. Helps with #5490.
@domenic domenic mentioned this issue Jan 6, 2021
3 tasks
@domenic
Copy link
Member

domenic commented Jan 6, 2021

Pull request up at #6269, although we could keep the discussion here.

domenic added a commit that referenced this issue Jan 19, 2021
In particular, remove their activation behavior, stop them from matching
:link and :visited, and stop suggesting that they be focusable areas.

This also includes a slight expansion and rearrangement of the link
element's section to make it clearer what hyperlinks created by <link>
are meant for, contrasting them to <a> and <area> hyperlinks.

Closes #4831. Closes #2617. Helps with #5490.
imhele added a commit to imhele/html that referenced this issue Feb 18, 2021
* Editorial: remove redundant "the"

* Meta: default branch rename

Also correct a broken link. Not even w3.org URLs are that cool.

Helps with whatwg/meta#174.

* Editorial: clean up calls to "parse a URL"

It actually takes a string, so calls should be clear about that.

* Review Draft Publication: January 2021

* Simplify <link>s

In particular, remove their activation behavior, stop them from matching
:link and :visited, and stop suggesting that they be focusable areas.

This also includes a slight expansion and rearrangement of the link
element's section to make it clearer what hyperlinks created by <link>
are meant for, contrasting them to <a> and <area> hyperlinks.

Closes whatwg#4831. Closes whatwg#2617. Helps with whatwg#5490.

* Meta: remove demos/offline/* (whatwg#6307)

These are no longer needed as of e4330d5.

* Meta: minor references cleanup

Use more HTTPS and drop obsolete HTML Differences reference.

* Editorial: anticlockwise → counterclockwise

We use en-US these days. Spotted in https://twitter.com/iso2022jp/status/1352601086519955456.

* Use :focus-visible in the UA stylesheet

See w3c/csswg-drafts#4278.

* Editorial: align with WebIDL and Infra

* Fix "update a style block" early return

The new version matches implementation reality and CSSWG resolution.

The algorithm was also inconsistent, as it looked at whether
the element was in a shadow tree or in the document tree, but it was
only specified to be re-run if the element becomes connected or
disconnected.

The CSSWG discussed this in
w3c/csswg-drafts#3096 (comment)
and http://wpt.live/shadow-dom/ShadowRoot-interface.html tests this.

This also matches closer the definition of <link rel="stylesheet">,
which does use connectedness (though it uses "browsing-context
connected", which is a bit different):
https://html.spec.whatwg.org/#link-type-stylesheet

* Modernize and refactor simple dialogs

This contains a small bug fix, in that confirm() and prompt() said
"return" in some cases instead of "return false" or "return null" as
appropriate.

Other notable changes, all editorial, are:

* Factoring out repeated "cannot show simple dialogs" steps, which will
  likely expand over time (see e.g. whatwg#6297).
* Separating out and explaining the no-argument overload of alert().
* Passing the document through to the "printing steps", instead of just
  having them talk about "this Window object".

* Meta: add definition markup for MessageEvent

* Remove <marquee> events

They are only supported by one engine (Gecko).

Closes whatwg#2957.

* Clarify when microtasks happen

* Ignore COEP on non-secure contexts

Fixes whatwg#6328.

* Editorial: update URL Standard integration

* Editorial: only invoke response's location URL once

Complements whatwg/fetch#1149.

* Track the incumbent settings and active script in Promise callbacks

Closes whatwg#5213.

* createImageBitmap(): stop clipping sourceRect to source's dimensions

It has been found in whatwg#6306 that this was an oversight at the time of its introduction. Current behavior goes against author expectations and no implementer has opposed the change to "no-clip".

Tests: web-platform-tests/wpt#27040.

Closes whatwg#6306.

* Remove CSP plugin-types blocking

With Flash not being supported anymore, the CSP directive plugin-types has lost its main reason for being and is being removed from the Content Security Policy specification: w3c/webappsec-csp#456.

This change removes references to the relevant algorithm from the Content Security Policy spec.

* Meta: set more dfn types

A follow-up to:

* whatwg#5694
* whatwg#5916

* Editorial: occuring → occurring

* Make all plugin-related APIs no-ops

Part of whatwg#6003.

* Disallow simple dialogs from different-origin domain iframes

Closes whatwg#5407.

* Revive @@iterator for PluginArray/MimeTypeArray/Plugin

@@iterator is implicitly installed by defining an indexed property getter. Since there is no other way to define it exclusively, this restores some methods back to being indexed getters.

This fixes an inadvertent observable behavior change in d4f07b8.

* Adjust web+ scheme security considerations to account for FTP removal

Also, network scheme is now reduced to HTTP(S) scheme.

Helps with whatwg#5375, but form submission issue remains.

See whatwg/fetch#1166 for context.

* Meta: export pause

Nobody but XMLHttpRequest take a dependency on this please. You have been warned.

Context: whatwg/xhr#311.

* Fix typo: ancestor → accessor

Fixes whatwg#6374.

Co-authored-by: Dominic Farolino <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
Co-authored-by: Domenic Denicola <[email protected]>
Co-authored-by: Emilio Cobos Álvarez <[email protected]>
Co-authored-by: Momdo Nakamura <[email protected]>
Co-authored-by: Jake Archibald <[email protected]>
Co-authored-by: Yutaka Hirano <[email protected]>
Co-authored-by: Shu-yu Guo <[email protected]>
Co-authored-by: Kaiido <[email protected]>
Co-authored-by: Antonio Sartori <[email protected]>
Co-authored-by: Michael[tm] Smith <[email protected]>
Co-authored-by: Ikko Ashimine <[email protected]>
Co-authored-by: Carlos IL <[email protected]>
Co-authored-by: Kagami Sascha Rosylight <[email protected]>
Co-authored-by: Simon Pieters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

5 participants