Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point out that we don't expect the creator Document to be kept alive #792

Closed
annevk opened this issue Mar 3, 2016 · 2 comments
Closed

Point out that we don't expect the creator Document to be kept alive #792

annevk opened this issue Mar 3, 2016 · 2 comments
Assignees
@annevk

Comments

@annevk
Copy link
Member

annevk commented Mar 3, 2016

The HTML Standard uses the creator Document concept for aliasing origin and referrer. Neither should really require the creator Document to be kept alive if there's no reason for it to exist anymore, but that's an optimization an implementation can make. We could point that out in a note.

See w3c/webappsec-secure-contexts#18 (comment) for context.
@annevk annevk added the good first issue Ideal for someone new to a WHATWG standard or software project label Mar 3, 2016
@annevk
Copy link
Member Author

annevk commented Mar 3, 2016

The alternative here is to instead store the origin (as an alias) and the referrer so other specifications don't start building insecure things on top of the creator Document.

@annevk annevk removed the good first issue Ideal for someone new to a WHATWG standard or software project label Mar 3, 2016
@Ms2ger
Copy link
Member

Ms2ger commented Mar 4, 2016

Storing just the state we need seems better to me.

annevk added a commit that referenced this issue Apr 4, 2016
@annevk
Remove the concept of creator Document so we don't leak a document
6b21b54 
Fixes #792.
@annevk annevk mentioned this issue Apr 4, 2016
Merged
domenic pushed a commit that referenced this issue Apr 5, 2016
@annevk @domenic
Remove the concept of creator Document so we don't leak a document
a996f3b 
Fixes #792.
jungkees pushed a commit to jungkees/html that referenced this issue Apr 8, 2016
@annevk @jungkees
Remove the concept of creator Document so we don't leak a document
d93e95b 
Fixes whatwg#792.
This was referenced Apr 3, 2017
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annevk annevk

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ms2ger @annevk