-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The spec language for enumerated attributes
is not consistent
#9832
Comments
Thanks for filing this. For anyone wanting to get some editing experience this would be a great issue to work on. Not everything has to be fixed in one go either, it's fine to tackle this one attribute at a time, say. For those coming here through "good first issue": note that we don't assign issues and you don't have to ask if this is still available. Just provide a PR. |
Thanks for filing this, and thanks @keithamus for your work here! It seems like the format we're settling on is similar to the following:
followed by a table with the columns "Keyword", "State", and "Brief description" (in that order). The table does not use closing tags, and the brief description does not have Some like After the table should come the definition of invalid value default and missing value default, as well as any canonicalization needed for reflection. The form of that should be something like
or
Some notes on the ones that don't use a table currently: referrer policy attributes and
|
Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. Editorial: Remove old FinishDynamicImport reference Restore early return for history.go(0) This accidentally was lost in 0a97a81. Editorial: add enumerated attribute table for draggable Helps with whatwg#9832. Editorial: add enumerated attribute table for form/autocomplete Helps with whatwg#9832. Fix PromiseRejectionEvent's promise attribute As discovered in whatwg/streams#1298 (comment), Promise<T> is actually not an appropriate type for it. Navigation API: add navigation.activation Closes whatwg#9760. Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832.
I think this issue can now be closed? Would anyone care to double check that we've got them all? (perhaps @mfreed7 😄) |
Amazing work; thank you!! Biggest easy thing I'd like to see fixed: inconsistent empty string keywords. We have one I'd also like to see the empty string keyword/state be consistently the first in the table, and the order be Other minor issue: for Un-updated attriutes:
Finally, we're inconsistent on whether state names are capitalized or lowercase. This is probably not worth fixing, but I could see it causing confusion in the future for people introducing new enumerated attributes and being unsure which to use. I was leaning toward lowercase but https://html.spec.whatwg.org/#the-button-element:enumerated-attribute
would be pretty confusing lowercased. |
Helps with #9832, by consistently using "(the empty string)" and placing such rows in the same place in the enumerated attribute tables.
Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. wip - failing wip so far c no parse error buildable buildable-success Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. c fix main document Editorial: remove closing tags on the dir attribute table Helps with whatwg#9832. add hr mc mc fix id and src desc
What is the issue with the HTML Standard?
This is a spec-only issue, nothing related to behavior.
The spec has a number of
<span>enumerated attribute</span>
s, and there are three things that are not consistent:<table>
of attribute values, while others use prose. Preferred: use a table.<table>
s, most do not have closing tags (e.g.</tr>
) while some do. Preferred: use closing tags.See the data below for which attributes fall into which camps.
Data
No closing tags
Has closing tags
Doesn't use a table
The text was updated successfully, but these errors were encountered: