Update 2D canvas color serialization #10481

annevk · 2024-07-15T12:12:40Z

Although fillStyle, strokeStyle, and shadowColor setters accepted all kinds of CSS color values, those could not be serialized. Update that by relying on CSS Color for serialization instead, which now has a HTMLCompatible named parameter to preserve compatibility with 2D canvas and for certain colors.

While here, also link the algorithm to be used for color space conversion and correct the reference for 'relative-colorimetric'.

Fixes #8917.

@Kaiido do you happen to know if we already have test coverage for this?

@weinig this might be of interest to you.

At least two implementers are interested (and none opposed):
- WebKit
- Chromium (per August 15 WHATNOT)
- Gecko (per August 15 WHATNOT)
Tests are written and can be reviewed and commented upon at:
- 2D canvas color parsing and serialization web-platform-tests/wpt#47148
Implementation bugs are filed:
- Chromium: N/A
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1919710
- WebKit: https://bugs.webkit.org/show_bug.cgi?id=278392
MDN issue is filed: N/A, bug fix
The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/canvas.html ( diff )
/infrastructure.html ( diff )

annevk · 2024-07-15T12:42:15Z

@whatwg/canvas @whatwg/css please review.

Kaiido · 2024-07-16T00:05:59Z

@Kaiido do you happen to know if we already have test coverage for this?

I think @mysteryDate did add tests for the serialization of color-mix() recently, but other serialization tests all seem to be about "HTMLCompatible" cases, so I guess new tests are needed, but Aaron will know better than me.

source

For whatwg/html#8917, w3c/csswg-drafts#10550, and whatwg/html#10481.

domenic

Let's get w3c/csswg-drafts#10550 (comment) resolved.

domenic · 2024-08-16T05:34:28Z

source

@@ -67772,8 +67773,9 @@ try {

  <ol>
   <li><p>If <span>this</span>'s <span data-x="concept-CanvasFillStrokeStyles-fill-style">fill
-   style</span> is a CSS color, then return the <span data-x="serialization of a
-   color">serialization</span> of that color.</p></li>
+   style</span> is a CSS color, then return the <span data-x="serialize a CSS &lt;color>


Preexisting issue, not necessary to fix: it'd be nice if "CSS color" linked to some definition, in all its usage sites.

it'd be nice if "CSS color" linked to some definition, in all its usage sites.

Agreed, I suggest https://drafts.csswg.org/css-color-4/#typedef-color

which says

Colors in CSS are represented by the <color> type:

@annevk what do you think, does that link work for you?

I've decided to not address this for now. I think what we want in HTML is mostly some kind of abstract concept and not a syntax construct. We want to reference what that gets parsed into in a number of places.

mysteryDate · 2024-09-04T14:22:10Z

@Kaiido do you happen to know if we already have test coverage for this?

I think @mysteryDate did add tests for the serialization of color-mix() recently, but other serialization tests all seem to be about "HTMLCompatible" cases, so I guess new tests are needed, but Aaron will know better than me.

I don't believe we have any tests for this for canvas specifically, those would go in the .yaml files in /html/canvas/. Quick search turns up nothing:

https://source.chromium.org/search?q=f:wpt%20f:canvas%20oklab&sq=package:chromium

I think that I didn't add any because I was waiting for the spec to update.

mysteryDate

This all looks good to me! Thanks for doing this @annevk !

For whatwg/html#8917, w3c/csswg-drafts#10550, and whatwg/html#10481.

svgeesus · 2024-09-17T13:47:29Z

@annevk does my suggested link to resolve @domenic comment work here?

annevk · 2024-09-17T13:50:07Z

@svgeesus I was out sick, hence the delay here. I think that works, but I see that @domenic hasn't replied yet to the recent updates to CSS Color which were primarily blocking this PR. I'll see about reviewing those now and supplying you with better examples.

Although fillStyle, strokeStyle, and shadowColor setters accepted all kinds of CSS color values, those could not be serialized. Update that by relying on CSS Color for serialization instead, which now has a HTMLCompatible named parameter to preserve compatibility with 2D canvas and <input type=color> for certain colors. While here, also link the algorithm to be used for color space conversion and correct the reference for 'relative-colorimetric'. Fixes #8917.

annevk · 2024-09-19T07:48:37Z

@domenic it now uses the "with HTML-compatible serialization requested" wording. Good enough? I'll file implementation bugs too.

…n, a=testonly Automatic update from web-platform-tests 2D canvas color parsing and serialization For whatwg/html#8917, w3c/csswg-drafts#10550, and whatwg/html#10481. -- wpt-commits: 6b71c578c4e9113e56b5445d4697b6a97aedf37d wpt-pr: 47148

…n, a=testonly Automatic update from web-platform-tests 2D canvas color parsing and serialization For whatwg/html#8917, w3c/csswg-drafts#10550, and whatwg/html#10481. -- wpt-commits: 6b71c578c4e9113e56b5445d4697b6a97aedf37d wpt-pr: 47148 UltraBlame original commit: ba0041c24e1332e588896b9fb72ed44e32f1a385

…n, a=testonly Automatic update from web-platform-tests 2D canvas color parsing and serialization For whatwg/html#8917, w3c/csswg-drafts#10550, and whatwg/html#10481. -- wpt-commits: 6b71c578c4e9113e56b5445d4697b6a97aedf37d wpt-pr: 47148

annevk added the topic: canvas label Jul 15, 2024

annevk mentioned this pull request Jul 15, 2024

[css-color-4] HTML needs an html-compatible, hex serialization of 8 bit/component sRGB colors w3c/csswg-drafts#10550

Closed

annevk mentioned this pull request Jul 15, 2024

Enhance <input type=color> with alpha and colorspace=display-p3 #10456

Merged

5 tasks

domenic reviewed Jul 16, 2024

View reviewed changes

source Outdated Show resolved Hide resolved

source Outdated Show resolved Hide resolved

annevk added a commit to web-platform-tests/wpt that referenced this pull request Jul 16, 2024

2D canvas color parsing and serialization

7991a1c

For whatwg/html#8917, w3c/csswg-drafts#10550, and whatwg/html#10481.

annevk mentioned this pull request Jul 16, 2024

2D canvas color parsing and serialization web-platform-tests/wpt#47148

Merged

annevk mentioned this pull request Aug 14, 2024

Canvas 2D context color serialization #8917

Closed

annevk requested review from domenic, svgeesus, kdashg and mysteryDate and removed request for svgeesus August 15, 2024 10:10

annevk added agenda+ To be discussed at a triage meeting and removed agenda+ To be discussed at a triage meeting labels Aug 15, 2024

past mentioned this pull request Aug 15, 2024

Upcoming WHATNOT meeting on 2024-08-15 #10556

Closed

domenic reviewed Aug 16, 2024

View reviewed changes

mysteryDate approved these changes Sep 4, 2024

View reviewed changes

annevk added a commit to web-platform-tests/wpt that referenced this pull request Sep 17, 2024

2D canvas color parsing and serialization

6b71c57

For whatwg/html#8917, w3c/csswg-drafts#10550, and whatwg/html#10481.

annevk added 2 commits September 19, 2024 09:34

feedback

ebab7ec

annevk force-pushed the annevk/canvas-colors branch from 4b44ed7 to ebab7ec Compare September 19, 2024 07:45

annevk requested a review from domenic September 19, 2024 07:45

Update source

a0e610b

domenic approved these changes Sep 19, 2024

View reviewed changes

annevk merged commit 236e055 into main Sep 19, 2024
2 checks passed

annevk deleted the annevk/canvas-colors branch September 19, 2024 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update 2D canvas color serialization #10481

Update 2D canvas color serialization #10481

annevk commented Jul 15, 2024 •

edited by pr-preview bot

Loading

annevk commented Jul 15, 2024

Kaiido commented Jul 16, 2024

domenic left a comment

domenic Aug 16, 2024

svgeesus Sep 5, 2024

svgeesus Sep 10, 2024

annevk Sep 19, 2024

mysteryDate commented Sep 4, 2024

mysteryDate left a comment

svgeesus commented Sep 17, 2024

annevk commented Sep 17, 2024

annevk commented Sep 19, 2024

Update 2D canvas color serialization #10481

Update 2D canvas color serialization #10481

Conversation

annevk commented Jul 15, 2024 • edited by pr-preview bot Loading

annevk commented Jul 15, 2024

Kaiido commented Jul 16, 2024

domenic left a comment

Choose a reason for hiding this comment

domenic Aug 16, 2024

Choose a reason for hiding this comment

svgeesus Sep 5, 2024

Choose a reason for hiding this comment

svgeesus Sep 10, 2024

Choose a reason for hiding this comment

annevk Sep 19, 2024

Choose a reason for hiding this comment

mysteryDate commented Sep 4, 2024

mysteryDate left a comment

Choose a reason for hiding this comment

svgeesus commented Sep 17, 2024

annevk commented Sep 17, 2024

annevk commented Sep 19, 2024

annevk commented Jul 15, 2024 •

edited by pr-preview bot

Loading