-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an 'allow-popups-to-escape-sandbox' sandboxing token. #14
Conversation
Hi, @domenic and @annevk! Thanks so much for doing the hard work to get things set up for direct, external contributions (and for letting me know about it)! I have no idea how to generate the spec documents from Does this look like a reasonable approach to resolving https://www.w3.org/Bugs/Public/show_bug.cgi?id=28817? If so, wonderful. I have a million more patches for you. :) |
Yeah, we need to document this. Would you mind giving the procedures set up in https://github.com/whatwg/html-build a try? Note that it's kind of sucky in two ways, currently:
I have visions of a web service that you upload a Would love your feedback on the build process, if you can manage to get it working. Any that you can give will be incorporated into the readme. |
@bzbarsky would you please go over this pull request to see whether you catch anything obviously wrong? Auxiliary browsing contexts is not my strong suit. |
Looks reasonable to me. |
Will do, whenever I can get to a computer today. |
This patch adds the sandbox-escaping functionality described at [1], which will allow a sandboxed docuent to spawn new windows without forcing the set of active sandboing flags upon them. This allows, for example, a third-party advertisement to be (more) safely sandboxed without forcing the same restrictions upon a landing page. Discussed at [2] and [3]. [1]: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28817 [2]: https://lists.w3.org/Archives/Public/public-whatwg-archive/2015May/0035.html [3]: https://groups.google.com/a/chromium.org/d/msg/blink-dev/wXbgxLu63Fo/YtsqkySmTWcJ
Rebased, thanks! |
This patch adds the sandbox-escaping functionality described at 1,
which will allow a sandboxed docuent to spawn new windows without
forcing the set of active sandboing flags upon them. This allows, for
example, a third-party advertisement to be (more) safely sandboxed
without forcing the same restrictions upon a landing page.