Do not fetch stylesheets in documents without a browsing context #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #1495 by changing the "appropriate times to obtain the resource" to require that the <link rel="stylesheet"> element be in a document that has a browsing context.
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1495 by changing the "appropriate times to obtain the
resource" to require that the
<link rel="stylesheet">element be in adocument that has a browsing context.
@jdm, look good? Thanks for raising this.
Note that there's also some more ongoing discussion that might change the exact semantics here in WICG/webcomponents#530. I was thinking of maybe introducing "in a browsing-context-having document" or something similar but wanted to at least wait until we figured that issue out first.