Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make <link rel="stylesheet"> work inside shadow trees #1572

Merged
merged 1 commit into from
Jul 20, 2016
Merged

Make <link rel="stylesheet"> work inside shadow trees #1572

merged 1 commit into from
Jul 20, 2016

Conversation

domenic
Copy link
Member

@domenic domenic commented Jul 19, 2016

@domenic domenic added normative change topic: shadow Relates to shadow trees (as defined in DOM) labels Jul 19, 2016
@annevk annevk merged commit 43c5786 into master Jul 20, 2016
@annevk annevk deleted the shadow-dom-link-stylesheet branch July 20, 2016 07:30
@ruphin ruphin mentioned this pull request Jun 7, 2019
Closed
@milkbump milkbump mentioned this pull request Jun 23, 2020
Open
@robertknight robertknight mentioned this pull request Dec 3, 2020
Merged
robertknight added a commit to hypothesis/client that referenced this pull request Feb 12, 2021
@robertknight
Switch to using <link> elements for stylesheets in shadow DOM
f52c32e 
When Shadow DOM was first considered for use in the client `<link
rel="stylesheet">` was not widely supported as a way to load external styles into
shadow roots. This was resolved in the spec in whatwg/html#1572
and has now long been supported by all browsers.

Using `<link>` simplifies the code and also avoids a possible problem with sites
that have a strict CSP policy that disallows inline styles. In the
browser extension context a `<link>` can still work in that scenario as long as the
stylesheet is loaded from a `chrome-extension://` URL.
@robertknight robertknight mentioned this pull request Feb 12, 2021
Merged
robertknight added a commit to hypothesis/client that referenced this pull request Feb 12, 2021
@robertknight
Switch to using <link> elements for stylesheets in shadow DOM
1d2eaf6 
When Shadow DOM was first considered for use in the client `<link
rel="stylesheet">` was not widely supported as a way to load external styles into
shadow roots. This was resolved in the spec in whatwg/html#1572
and has now long been supported by all browsers.

Using `<link>` simplifies the code and also avoids a possible problem with sites
that have a strict CSP policy that disallows inline styles. In the
browser extension context a `<link>` can still work in that scenario as long as the
stylesheet is loaded from a `chrome-extension://` URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
normative change topic: link topic: shadow Relates to shadow trees (as defined in DOM)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @annevk