Remove anchored positioning of <dialog>s #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was mentioned briefly in the discussion in #1929. <dialog> only has one implementation currently, and that implementation is not planning to implement the anchoring feature, per https://bugs.chromium.org/p/chromium/issues/detail?id=410346.
|
Sounds good to me. I had a feeling that there are various issues around anchored positioning, and was going to look into the spec deeply. It seems there is no such need to do this anymore now :) |
zcorpan
approved these changes
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mentioned briefly in the discussion in #1929. <dialog> only has
one implementation currently, and that implementation is not planning to
implement the anchoring feature, per
https://bugs.chromium.org/p/chromium/issues/detail?id=410346.