Remove the concept of "dialog group" #3566
Conversation
source
Outdated
| group</span>, if any, or else the first <code>dialog</code> in the <span>dialog group</span> regardless of | ||
| <span data-x="inert">inertness</span>, must be designated the <span>focused dialog of the dialog | ||
| group</span>.</p> | ||
|
|
||
| <p><dfn>Focus fixup rule one</dfn>: When the designated <span data-x="focused area of the control |
There was a problem hiding this comment.
Should this now become "focus fixup rule"? Might be good to look at blame. (Also a little unsure who can review this since nobody is very familiar with focus handling.)
There was a problem hiding this comment.
Made it "focus fixup rule".
I'll check the blame history in more detail, but it seems it dates back in Hixie's days,
and seems hard to track down.
It used to have 3 rules, but now only one.
source
Outdated
| designated <span>focused dialog of the dialog group</span>, otherwise, it is the <span>primary | ||
| control group</span> of <var>X</var>'s <span>dialog group</span>'s designated | ||
| <span>focused dialog of the dialog group</span>.</p> | ||
| <p>The <dfn>primary control group</dfn> of a <span>control group owner object</span> <var>X</var> is the <span>control group</span> of <var>X</var>.</p> |
There was a problem hiding this comment.
Can you remove the concept of "primary control group" entirely and just use "control group" everywhere now?
There was a problem hiding this comment.
"primary control group" is only used in the table of sequential navigation search algorithm twice, so your suggestion looks working well.
TakayoshiKochi
force-pushed
the
dialog_group
branch
from
e0567b2
to
b641180
Compare
|
FWIW, f96b199 introduced the focus fixup rules and it started out with all of them. But that rewrite seemed to want to address a lot of things and it's unclear whether it's all supported by tests. I guess that's the main thing to focus (haha) on, ensure test coverage for all the things. |
|
@annevk thanks for the pointer! and I will work on test coverage as well. |
There used to be multiple focus fixup rules, but they were collapsed into a single one in whatwg/html#3566
There used to be multiple focus fixup rules, but they were collapsed into a single one in whatwg/html#3566
Automatic update from web-platform-tests Fix links to focus fixup rule There used to be multiple focus fixup rules, but they were collapsed into a single one in whatwg/html#3566 -- wpt-commits: 6c97724b71c820eb502b3a246a2858e07c781aeb wpt-pr: 31960
This change mechanically removes the concept of "dialog group", its definition, and its references.
Originally "dialog group" seems to define the focusing behavior of nested dialogs in recursive
manner, but actual implementation doesn't follow the definition and this is not necessary.
This is a step forward to remove "control groups" completely to address #2171
/interaction.html ( diff )