Pass a request, rather than URL, to Navigate algorithm #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@annevk, can you take a look? |
annevk
reviewed
Apr 23, 2018
source
Outdated
| substeps:</p> | ||
|
|
||
| <ol> | ||
|
|
annevk
reviewed
Apr 23, 2018
source
Outdated
| this case, the navigation will result in a different page than previously; for example, it | ||
| might be an error message explaining the problem or offering to resubmit the form.</p> | ||
| </li> | ||
|
|
annevk
reviewed
Apr 23, 2018
|
I'll set request's history-navigation flag for w3c/ServiceWorker#1167 in a subsequent change. You once talked about setting request's method depending on the history entry, this change would also be beneficial for that change. |
|
I addressed some nits, but upon further reading it seems this introduces a regression as you no longer return. I'll fix that, but someone else will need to review again to make sure we haven't missed anything. |
|
Thanks! |
domenic
approved these changes
Apr 25, 2018
source
Outdated
| <li> | ||
| <p><span>Navigate</span><!--DONAV history traversal after eviction--> the <span>browsing | ||
| context</span> to <var>request</var> to perform an <span>entry update</span> of | ||
| <var>entry</var> and return. The navigation must be done using the same <span>source browsing |
There was a problem hiding this comment.
"And return" was really easy to miss here since there's a sentence and two notes after it. I'd suggest making it step 1.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary refactoring for history-navigation request attribute introduction. With this change,
Traverse the history algorithm passes a request, rather than a URL, to Navigate algorithm. This change
doesn't change the behavior.
/browsing-the-web.html ( diff )