-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set request's history-navigation flag for history traversal #3674
Conversation
Editorially this looks fine, but I have a hard time telling if the step is inserted at the right place to cause the intended effect. For example, I'm unsure whether we want this flag set for all navigations to new HTML documents (which invoke "update the session history with the new page" and thus this algorithm), and I'm unsure whether we want to exclude setting it for bfcache navigations (i.e. cases where step 1 of this algorithm is not true). @annevk, I thought you were more involved with this; can you help confirm? |
Well, I'm still skeptical about the whole navigate algorithm being correct, but you all wanted to move ahead with these things so changes to HTML I'm trying not to say too much about. |
(Those do sound like problems though.) |
Thank you!
You're right. What I was trying to set the flag was requests via traverse the history by a delta, so I fixed the change.
If entry holds a Document, Navigate algorithm is not called and service workers cannot see the request, right? |
@domenic , what do you think about the latest change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay; I had TC39 this week. The latest version looks good to me. I made further editorial tweaks around how the different flags to that algorithm are used; we don't have a fully consistent style across the spec, but this one seems a bit better.
See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167.
And also a member on the request concept (history-navigation flag) to support this API. See w3c/ServiceWorker#1167 for the discussion that led to this. Tests: web-platform-tests/wpt#10909. Corresponding HTML change: whatwg/html#3674.
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909 UltraBlame original commit: 28a4916ff9d5655c7b816da2a9d4c7746f664304
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909 UltraBlame original commit: 28a4916ff9d5655c7b816da2a9d4c7746f664304
…n, a=testonly Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167. -- wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d wpt-pr: 10909 UltraBlame original commit: 28a4916ff9d5655c7b816da2a9d4c7746f664304
See w3c/ServiceWorker#1167 for the discussion that led to this change and whatwg/fetch#718 for the infrastructure in Fetch this builds upon.
Tests: web-platform-tests/wpt#10909
/acknowledgements.html ( diff )
/browsing-the-web.html ( diff )
/history.html ( diff )
/infrastructure.html ( diff )