-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document.open(): remove fragment before propagating entry document's URL #3970
Conversation
For whatwg/html#3970. Co-authored-by: Timothy Gu <[email protected]>
For whatwg/html#3970. Co-authored-by: Timothy Gu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, we better align with Safari and Chrome if we guard the URL and history update states behind "If entry is not document" as well. So, we should do that.
Testing the difference between that and the current PR will require writing a test to show that in such cases POSTs don't get converted to GET. I'm sorry :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, as discussed further offline, my argument about delta from today's implementations was not sensible. All implementations will have to make small changes in this area, either with this PR's current version or with my suggested tweak to it. And those changes are of similar magnitude in both cases.
I still think it might be a bit nicer to have one if statement governing all this "weird URL-related stuff". But @TimothyGu is the expert, so I will trust his judgment that this is the best path.
Indeed, as with the other |
For whatwg/html#3970. Co-authored-by: Timothy Gu <[email protected]>
… (with fragments), a=testonly Automatic update from web-platform-testsHTML: document.open() and document's URL (with fragments) For whatwg/html#3970. Co-authored-by: Timothy Gu <[email protected]> -- wpt-commits: d2cffc6c5ec316e0269cf2809cba090153ea29ba wpt-pr: 10817
… (with fragments), a=testonly Automatic update from web-platform-testsHTML: document.open() and document's URL (with fragments) For whatwg/html#3970. Co-authored-by: Timothy Gu <[email protected]> -- wpt-commits: d2cffc6c5ec316e0269cf2809cba090153ea29ba wpt-pr: 10817
… (with fragments), a=testonly Automatic update from web-platform-testsHTML: document.open() and document's URL (with fragments) For whatwg/html#3970. Co-authored-by: Timothy Gu <timothygu99gmail.com> -- wpt-commits: d2cffc6c5ec316e0269cf2809cba090153ea29ba wpt-pr: 10817 UltraBlame original commit: 58e1e3b29ba385cc708b828728ec973bb878efac
… (with fragments), a=testonly Automatic update from web-platform-testsHTML: document.open() and document's URL (with fragments) For whatwg/html#3970. Co-authored-by: Timothy Gu <timothygu99gmail.com> -- wpt-commits: d2cffc6c5ec316e0269cf2809cba090153ea29ba wpt-pr: 10817 UltraBlame original commit: 58e1e3b29ba385cc708b828728ec973bb878efac
… (with fragments), a=testonly Automatic update from web-platform-testsHTML: document.open() and document's URL (with fragments) For whatwg/html#3970. Co-authored-by: Timothy Gu <timothygu99gmail.com> -- wpt-commits: d2cffc6c5ec316e0269cf2809cba090153ea29ba wpt-pr: 10817 UltraBlame original commit: 58e1e3b29ba385cc708b828728ec973bb878efac
This is another part of the effort to overhaul
document.open()
as outlined in #3818.Tests: web-platform-tests/wpt#10817
Fixes #2555.