Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor browsing context creation #4284

Merged
merged 13 commits into from
Jan 29, 2019
Merged

Refactor browsing context creation #4284

Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e7311e5
Refactor browsing context creation
annevk Jan 11, 2019
01cc8aa
nits
annevk Jan 11, 2019
913c61c
more nits
annevk Jan 15, 2019
c55e64d
Make some slight corrections
annevk Jan 22, 2019
7d85f7e
preserve status quo on name setting
annevk Jan 22, 2019
b65178f
sandboxing affects non-auxiliary top-level too
annevk Jan 22, 2019
532713e
incorperate #4318
annevk Jan 24, 2019
6c77a71
sigh why is error information wrong
annevk Jan 24, 2019
a4ffb2f
tada
annevk Jan 24, 2019
28f5cf3
window.open() usually sets opener browsing context because why not
annevk Jan 24, 2019
1bfdc89
address review feedback
annevk Jan 25, 2019
5ac6db8
maybe i should build locally
annevk Jan 25, 2019
736d30c
clarify top-level bc creation and fix disowned boolean phrasing
annevk Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading