Custom elements: Add element.attachInternals() and ElementInternals interface #4324

tkent-google · 2019-01-28T07:09:43Z

This fixes WICG/webcomponents#758

WPT: web-platform-tests/wpt#15123
WPT: web-platform-tests/wpt#15516

/custom-elements.html ( diff )
/dom.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )

…nterface This fixes WICG/webcomponents#758

tkent-google · 2019-01-28T09:03:08Z

@domenic Would you review this please?
I'll make a WPT PR soon.

source

Specification PR: whatwg/html#4324

domenic

Looks good with some nits! Unsure when we should land, as adding a no-op interface to the spec feels a bit silly, but let me know what you think.

source

tkent-google · 2019-02-14T10:00:34Z

@domenic

Unsure when we should land, as adding a no-op interface to the spec feels a bit silly, but let me know what you think.

I also feel it's silly, however I'd like to merge this PR with the empty interface. It makes writing the next PR easier and makes the next PR smaller.
AFAIK, GitHub doesn't support dependent PRs.

annevk · 2019-02-14T10:15:32Z

@tkent-google you can create a new PR that contains these commits as well as the new commit. You'd have to rebase once this is merged and force push.

domenic

LGTM.

I would be OK merging this now as long as we added a warning to the ElementInternals section saying "for now this interface has no functionality; follow [tracking bug] to watch progress on adding it." Or, we could do the dependent PRs, like @annevk said.

…5123) Specification PR: whatwg/html#4324

tkent-google · 2019-02-21T10:17:26Z

Ok, I'm trying @annevk's suggestion. The next PR is #4383 .

…res'. This change is for whatwg/html#4324, and a follow-up of #15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa

so that it matches to a specification PR; whatwg/html#4324 - Check 'is value' for customized built-in elements - Throws NotSupportedError instead of InvalidStateError in some cases - Remove the upstreamed test Bug: 905922 Change-Id: Ibe8db0ecde129f09a70c273cdc526f578ace1c33 Reviewed-on: https://chromium-review.googlesource.com/c/1482272 Auto-Submit: Kent Tamura <[email protected]> Commit-Queue: Hayato Ito <[email protected]> Reviewed-by: Hayato Ito <[email protected]> Cr-Commit-Position: refs/heads/master@{#635024}

…res'. This change is for whatwg/html#4324, and a follow-up of #15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Hayato Ito <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/master@{#635380}

…res'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Hayato Ito <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/master@{#635380}

…res'. This change is for whatwg/html#4324, and a follow-up of #15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Hayato Ito <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/master@{#635380}

…Element.attachInternals(), a=testonly Automatic update from web-platform-tests html,custom-elements: Add tests for HTMLElement.attachInternals() (#15123) Specification PR: whatwg/html#4324 -- wpt-commits: 4c70b5a6f3169400dc809ba540b8e4e425396b2d wpt-pr: 15123

…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Hayato Ito <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/master@{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516

annevk · 2019-05-15T09:54:11Z

source

+
+   <li><p>If <var>definition</var>'s <span
+   data-x="concept-custom-element-definition-disable-internals">disable internals</span> is true,
+   then throw a <span>"<code>NotSupportedError</code>"</span> <code>DOMException</code>.</p></li>


As with attachShadow(), I don't think we should expose whether it's disabled or previously used. The same exception should be used for both.

Follows latest developments in whatwg/html#4324.

domenic · 2019-05-15T19:13:34Z

Follows latest developments in whatwg/html#4324.

This was discussed as part of WICG/webcomponents#758, and integrates with whatwg/html#4324.

domenic · 2019-05-16T20:23:56Z

Bugs for ElementInternals/attachInternals/disabledFeatures:

I'll let tkent determine whether we want any more tracking bugs on the Blink side.

…ls(), a=testonly Automatic update from web-platform-tests Update error type test for attachInternals() (#16856) Follows latest developments in whatwg/html#4324. -- wp5At-commits: dc4519e0a9b6a0b5f53e622a31b420cb22d3a100 wpt-pr: 16856

…5123) Specification PR: whatwg/html#4324

…res'. This change is for whatwg/html#4324, and a follow-up of #15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Hayato Ito <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/master@{#635380}

Follows latest developments in whatwg/html#4324.

…Element.attachInternals(), a=testonly Automatic update from web-platform-tests html,custom-elements: Add tests for HTMLElement.attachInternals() (#15123) Specification PR: whatwg/html#4324 -- wpt-commits: 4c70b5a6f3169400dc809ba540b8e4e425396b2d wpt-pr: 15123 UltraBlame original commit: 2f7275c284b18453bbbbfc0eb474542588bcb65e

…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkentchromium.org> Reviewed-by: Hayato Ito <hayatochromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/master{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516 UltraBlame original commit: 91b75e0e8324befa1731b448285c8bcc9411d410

…Element.attachInternals(), a=testonly Automatic update from web-platform-tests html,custom-elements: Add tests for HTMLElement.attachInternals() (#15123) Specification PR: whatwg/html#4324 -- wpt-commits: 4c70b5a6f3169400dc809ba540b8e4e425396b2d wpt-pr: 15123 UltraBlame original commit: fd7d7f58d4afb2159a5d7d55d94169932e464326

…istry.html for 'disabledFeatures'., a=testonly Automatic update from web-platform-tests custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'. This change is for whatwg/html#4324, and a follow-up of web-platform-tests/wpt#15123 Bug: crbug.com/905922 Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa Reviewed-on: https://chromium-review.googlesource.com/c/1482361 Auto-Submit: Kent Tamura <tkentchromium.org> Reviewed-by: Hayato Ito <hayatochromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/master{#635380} -- wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611 wpt-pr: 15516 UltraBlame original commit: e89bf41687f50e862ace8bb7077aaa06e2f6a8b9

…ls(), a=testonly Automatic update from web-platform-tests Update error type test for attachInternals() (#16856) Follows latest developments in whatwg/html#4324. -- wp5At-commits: dc4519e0a9b6a0b5f53e622a31b420cb22d3a100 wpt-pr: 16856 UltraBlame original commit: a29b743876db0cb6b71a0b169456d98409803000