Clarify Document and Window's browsing context slot #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Feb 15, 2019
There was a problem hiding this comment.
LGTM, very nice. Suggested commit message (in particular I don't think Window has a BC "slot" per se):
Clarify Document and Window's browsing contexts
Previously, a Document could sometimes "have no browsing context". Now,
"a Document's browsing context" is either a browsing context or null.
Previously, "a Window's browsing context" was not defined, despite being
referenced extensively. Now, it is defined to be the Window's associated
Document's browsing context.
Related to #3846, #4363, and #4366.
TimothyGu
reviewed
Feb 16, 2019
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 17, 2019
|
I tweaked that sentence. This should be in order now. Tests for rewritten |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Mar 16, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 16, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Mar 17, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414 UltraBlame original commit: 3d06a920925d1d2beb8dbe5d3fb7a686155a7000
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414 UltraBlame original commit: 8566ae4d152605453ebe6715ec4f2f8af60a95d3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414 UltraBlame original commit: 3d06a920925d1d2beb8dbe5d3fb7a686155a7000
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414 UltraBlame original commit: 8566ae4d152605453ebe6715ec4f2f8af60a95d3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414 UltraBlame original commit: 3d06a920925d1d2beb8dbe5d3fb7a686155a7000
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…testonly Automatic update from web-platform-tests HTML: window.length and named access For whatwg/html#4368. -- wpt-commits: 3a43f99a56a4c016e3f1cda41330f1a2c0e780ff wpt-pr: 15414 UltraBlame original commit: 8566ae4d152605453ebe6715ec4f2f8af60a95d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infrastructure for #3846 and #4363.
/browsers.html ( diff )
/custom-elements.html ( diff )
/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/form-control-infrastructure.html ( diff )
/history.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )
/interaction.html ( diff )
/interactive-elements.html ( diff )
/origin.html ( diff )
/parsing.html ( diff )
/scripting.html ( diff )
/webappapis.html ( diff )
/window-object.html ( diff )