Clarify Window's focus() and blur() #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular when there's a null browsing context, for #4363. Tests: web-platform-tests/wpt#15460.
zcorpan
approved these changes
Feb 19, 2019
domenic
added
clarification
domenic
requested changes
Feb 21, 2019
| provides a hint to the user agent that the script believes the user probably is not currently | ||
| interested in the contents of this <code>Window</code> object's <span data-x="window bc">browsing | ||
| context</span>, if non-null, but that the contents might become interesting again in the | ||
| future.</p> |
There was a problem hiding this comment.
This could become a three-step algorithm.
- User agents should return at this point, causing the method to do nothing.
- If the BC is null, return.
- If this point is reached, then the page author has provided a hint...
Note that it does nothing in Blink (1, 2). It seems to do something in Safari, sometimes (1, 2). I couldn't untangle Gecko's mess of window-related classes enough to find the blur method implementation there.
|
I've fixed the minor nits, but let's leave the bigger |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 22, 2019
domenic
approved these changes
Feb 22, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Mar 16, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 16, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Mar 17, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460 UltraBlame original commit: 4e667891d3088a94002b74336f2a6ab7933d0d21
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460 UltraBlame original commit: d3eedffa9545cd523e3632aac00c7336c056cbc6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460 UltraBlame original commit: 4e667891d3088a94002b74336f2a6ab7933d0d21
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460 UltraBlame original commit: d3eedffa9545cd523e3632aac00c7336c056cbc6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460 UltraBlame original commit: 4e667891d3088a94002b74336f2a6ab7933d0d21
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…xt, a=testonly Automatic update from web-platform-tests HTML: window.focus() sans browsing context For whatwg/html#4377. -- wpt-commits: 84a44957233c13fb21f5d97b06db1d89076fb144 wpt-pr: 15460 UltraBlame original commit: d3eedffa9545cd523e3632aac00c7336c056cbc6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular when there's a null browsing context, for #4363.
Tests: web-platform-tests/wpt#15460.
/interaction.html ( diff )