Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "is unloading" more explicit in navigation #5666

Merged
merged 1 commit into from
May 10, 2021
Merged

Commits on May 7, 2021

  1. Tweak "is unloading" in navigation

    This replaces vague text about "if the prompt to unload algorithm is
    being run" and the like for "unload" with an explicit check of the
    "unload counter". The "unload counter" is a rename of the
    "ignore-opens-during-unload counter", which was already used for similar
    explicit checks in document.open().
    
    This results in the same check being done everywhere, which appears to
    match at least some implementations better. Previously, for example,
    "traverse the history by a delta" did not check for beforeunload, only
    unload.
    domenic committed May 7, 2021
    Configuration menu
    Copy the full SHA
    1299798 View commit details
    Browse the repository at this point in the history