Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change initial about:blank navigation behavior for iframes and popups #6869

Merged
merged 8 commits into from
Aug 10, 2021
Merged

Change initial about:blank navigation behavior for iframes and popups #6869

merged 8 commits into from
Aug 10, 2021

Commits on Jul 16, 2021

  1. Do not navigate to about:blank on iframe insertion 

    Previously, we did a confusing thing where we would navigate to a non-initial about:blank. 2/3 engines instead do something observably equivalent to not navigating at all; they just fire a load event. This is much simpler, and matches window.open().

Closes #6863.
    @domenic
    domenic committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    2f751c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. No load events anywhere

    @domenic
    domenic committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    bdf3e17 View commit details
    Browse the repository at this point in the history

  2. Fix bug in last commit and refactor window open steps a lot

    @domenic
    domenic committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    a39ae5e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Review comments

    @domenic
    domenic committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    af0c760 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Do *not* check query and fragment

    @domenic
    domenic committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    cd5f327 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. URL and history update steps

    @domenic
    domenic committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    e0dc4c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Fire the load event sync

    @domenic
    domenic committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    5bc2d13 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Expand the note per review

    @domenic
    domenic committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    504d117 View commit details
    Browse the repository at this point in the history