Remove concept of "expressly inert" #7565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems a remnant of control groups, which were removed in whatwg#3647. All uses are replaced with the concept of "inert". Also cleaning up "When a key event is to be routed in a top-level browsing context", which also seems to have remnants of when control groups allowed inert elements inside an inert dialog to be focusable. Fixes whatwg#7564.
Loirooriol
force-pushed
the
remove-expressly-inert
branch
from
1a7f181
to
ca03c6b
Compare
|
Can you join or make public your membership in the |
|
I made my Igalia membership public |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 3, 2022
The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 7, 2022
The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 7, 2022
The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 7, 2022
The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045}
mattwoodrow
pushed a commit
to mattwoodrow/wpt
that referenced
this pull request
Feb 15, 2022
The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 26, 2022
…nert" with "inert", a=testonly Automatic update from web-platform-tests [inert] Replace mentions of "expressly inert" with "inert" The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045} -- wpt-commits: c909db1182a7aa150e7aca7574b7baf55c2675a3 wpt-pr: 32686
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Feb 28, 2022
The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045}
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 1, 2022
…nert" with "inert", a=testonly Automatic update from web-platform-tests [inert] Replace mentions of "expressly inert" with "inert" The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045} -- wpt-commits: c909db1182a7aa150e7aca7574b7baf55c2675a3 wpt-pr: 32686
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 8, 2022
…nert" with "inert", a=testonly Automatic update from web-platform-tests [inert] Replace mentions of "expressly inert" with "inert" The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045} -- wpt-commits: c909db1182a7aa150e7aca7574b7baf55c2675a3 wpt-pr: 32686
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 8, 2022
…nert" with "inert", a=testonly Automatic update from web-platform-tests [inert] Replace mentions of "expressly inert" with "inert" The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045} -- wpt-commits: c909db1182a7aa150e7aca7574b7baf55c2675a3 wpt-pr: 32686
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
The concept of "expressly inert" in the HTML spec was a remnant from the past. It no longer made sense, and wasn't implemented anywhere. I removed it in whatwg/html#7565 This patch replaces all mentions with just "inert". No change in behavior. Bug: 692360 Change-Id: I5bb76e633b13ee244eb69ad5e99ce9d9705073aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438605 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Oriol Brufau <[email protected]> Cr-Commit-Position: refs/heads/main@{#968045} NOKEYCHECK=True GitOrigin-RevId: 2ea73d6db67826e482eb6352d7f783e4117ac2da
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems a remnant of control groups, which were removed in #3647.
All uses are replaced with the concept of "inert".
Also cleaning up "When a key event is to be routed in a top-level
browsing context", which also seems to have remnants of when control
groups allowed inert elements inside an inert dialog to be focusable.
Fixes #7564.
The change is mostly editorial, the only effect that I can see is that
when a browsing context container is inert, the elements in its nested
browsing context were inert but focusable, now they won't be focusable.
They were already not focusable in Blink, and WebKit and Gecko don't
propagate inertness into nested browsing contexts, so they are not
affected.
/acknowledgements.html ( diff )
/interaction.html ( diff )