Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that modal dialogs escape inertness of ancestors. #7905

Merged
merged 2 commits into from
May 18, 2022

Conversation

emilio
Copy link
Contributor

@emilio emilio commented May 9, 2022

(See WHATWG Working Mode: Changes for more details.)


/interaction.html ( diff )

@emilio emilio changed the title Clarify that modal dialog escape inertness of ancestors. Clarify that modal dialogs escape inertness of ancestors. May 9, 2022
@emilio emilio requested review from annevk, domenic and nt1m May 9, 2022 13:40
Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@nt1m
Copy link
Member

nt1m commented May 9, 2022

The commit should have "Closes #7808." in the message.

@Loirooriol
Copy link
Contributor

§6.3.2 still says "all its flat tree descendants are to be made inert". I think this should exclude subtrees of nodes that "escape inertness".

@domenic
Copy link
Member

domenic commented May 18, 2022

§6.3.2 still says "all its flat tree descendants are to be made inert". I think this should exclude subtrees of nodes that "escape inertness".

This seems like a good idea, even though that text is just a summary. Emilio, can you make this update?

@emilio
Copy link
Contributor Author

emilio commented May 18, 2022

Done! And sorry @Loirooriol, I had missed the previous notification.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@domenic domenic added clarification Standard could be clearer topic: dialog The <dialog> element. labels May 18, 2022
@domenic domenic merged commit 3811489 into whatwg:main May 18, 2022
@domenic
Copy link
Member

domenic commented May 18, 2022

I forgot to say: please remember to update the tests, and report back to this thread when that's done.

@nt1m
Copy link
Member

nt1m commented May 18, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer topic: dialog The <dialog> element.
Development

Successfully merging this pull request may close these issues.

4 participants