-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "user attention" definition to top-level traversable. #8466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the long delay here. This looks pretty good to me.
Are you also planning on making various specifications adopt this once this lands? Or should we try to do that in a more coordinated fashion?
I've opened w3c/mediacapture-main#934 to take care of that spec, which is my main motivation. I haven't contributed to the other two specs mentioned in the issue OP, so volunteers would be great! If none, I can try to shoe something in, just don't want to step on any toes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this ended up. Two minor comments remain.
@domenic I think you should have a look as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with nits
"<code data-x="">visible</code>", and it either has <span>system focus</span> or user agent | ||
widgets directly related to it can receive keyboard input channeled from the operating system.</p> | ||
|
||
<p class="note">User attention is lost when a browser window loses focus, whereas system focus might |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean by browser window losing focus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means the browser window lost keyboard focus, which seems consistent with existing language in notes:
The note in this PR attempts to clarify the difference between user attention and system focus which both operate on that (the ability to "receive keyboard input channeled from the operating system").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed some wrapping nits. Let's merge this.
Thanks a lot @jan-ivar for making this happen! |
Fixes #6211 potentially. @annevk is this close to what you had in mind?
Is this editorial? I dunno. It adds no new API, only a concept sought by other specs listed in the OP of #6211. Tests and implementation bugs seem up to individual specs when/if they decide to rely on this new concept, if doing so ends up influencing said specs to change any observable behavior.
/interaction.html ( diff )