-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse disowned into opener browsing context #8573
Conversation
If you have a same-origin iframe handy, this should work: const getter = Object.getOwnPropertyDescriptor(frames[0], "opener").get;
const actualOpener = getter.call(popupWindow); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normative changes look good, but we should keep the note in some form.
Tests: TODO. Fixes #5569.
6d21701
to
c5a45da
Compare
I'm no longer convinced my first suggested test case is good. I think you might end up with two popups due to #313. I created a test case for the second case: web-platform-tests/wpt#38447. |
Automatic update from web-platform-tests HTML: set opener to a string For whatwg/html#8573. -- wpt-commits: 56df3bcc084365faeb2aa67ea937a927c5986e7a wpt-pr: 38447
Automatic update from web-platform-tests HTML: set opener to a string For whatwg/html#8573. -- wpt-commits: 56df3bcc084365faeb2aa67ea937a927c5986e7a wpt-pr: 38447
Automatic update from web-platform-tests HTML: set opener to a string For whatwg/html#8573. -- wpt-commits: 56df3bcc084365faeb2aa67ea937a927c5986e7a wpt-pr: 38447
Tests: TODO. Ideas:
Fixes #5569.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/document-sequences.html ( diff )
/nav-history-apis.html ( diff )