Support dfn types short syntax, "for", (no)export #134
Conversation
This change adds support for doing the following with attributes of dfn elements: * recognize attributes with names that are known dfn types (currently, 'element', 'element-attr', 'event', 'interface', 'extended-attribute', 'method', 'attribute', 'enum-value', and 'http-header'), and replace them with data-dfn-type=element, etc., attributes in output * for any dfn element that has an attribute named "for", replace it in output with an attribute named "data-dfn-for" * for any dfn element with an attribute named "export" or "noexport", replace it with one named "data-export" or "data-noexport" Relates to whatwg/html#5694
|
Will give this a closer look on Monday, but at first glance your inference seems exactly right. I'm very excited about this! |
There was a problem hiding this comment.
Code LGTM with suggested additions. Have you tested this on whatwg/html#5694? In particular it'd be good to make sure this code runs at the right "phase" so that things end up as expected; I feel like our MDN panels work ran into phase problems so it's good to check.
Hmm, also, can we strip these attributes out of the developer edition and review drafts?
There was a problem hiding this comment.
https://github.com/whatwg/html/pull/5694/files contains "noexport" but this doesn't translate those.
oops, thanks for catching that — will fix |
...because this got overlooked in the previous commit.
This change causes Wattsi to fail with an error message if a dfn that has a type name is found to also have an export attribute.
Fixed now |
This change makes Wattsi recognize the full set of 40 dfn types from https://github.com/tabatkins/bikeshed/blob/master/bikeshed/config/dfnTypes.py#L7 — rather than just the subset of 9 types the initial code recognized. Two dfn types that are used in HTML but that weren’t part of that initial subset (and that therefore weren’t getting converted as expected) are “attr-value” and “constructor”.
Let’s go ahead and merge this and then I can follow up with a separate patch for the |
sideshowbarker
deleted the
sideshowbarker/bikeshed-short-syntax-for-dfn-types
branch
This change adds support for doing the following with attributes of
dfnelements:recognize attributes with names that are known dfn types (currently:
element,element-attr,event,interface,extended-attribute,method,attribute,enum-value, andhttp-header), and replace them with correspondingdata-dfn-type=element, etc., attributes in outputfor any
dfnelement that has an attribute namedfor, replace it in output with an attribute nameddata-dfn-forfor any
dfnelement with anexportornoexportattribute , replace it with one nameddata-exportordata-noexportRelates to whatwg/html#5694
This patch does what I’ve inferred the desired behavior is, based on what I understand from the whatwg/html#5694. But it’s possible I’m misunderstanding. If so, I’m quite happy to iterate on this further (or completely re-do it…).