Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give SharedArrayBuffer a dedicated type #1311

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Commits on May 30, 2023

  1. Give SharedArrayBuffer a dedicated type

    Generally IDL objects have been 1:1 with ECMAScript objects, except for
    SharedArrayBuffer. That was instead represented as
    [AllowShared] ArrayBuffer, although that includes ArrayBuffer as well.
    This created a number of challenges, e.g., how to return a
    SharedArrayBuffer object.
    
    So we make these changes here that will also require corresponding
    downstream fixes:
    
    * SharedArrayBuffer is now its own type.
    * [AllowShared] only applies to buffer view types.
    * AllowSharedBufferSource takes over from [AllowShared] BufferSource.
    
    Fixes #865 and fixes #961.
    annevk committed May 30, 2023
    Configuration menu
    Copy the full SHA
    273bedf View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Review

    - Turn the table into a proper table instead of using <br>.
    - Attempt to link ECMAScript for certain ArrayBuffer/SharedArrayBuffer references.
    - Use typedefs for the buffer source type algorithms again and don't change the for attribute (mostly).
    - Drop the IsSharedArrayBuffer asserts when we already (implicitly) assert it's an ArrayBuffer.
    annevk committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    cfafa34 View commit details
    Browse the repository at this point in the history
  2. CI

    annevk committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    7087936 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. review

    annevk committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    22af0e5 View commit details
    Browse the repository at this point in the history
  2. CI

    annevk committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9ad215c View commit details
    Browse the repository at this point in the history