Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make response headers available to caller #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

charlieok
Copy link

This is especially useful for the rate limit headers returned by fitbit's api
https://wiki.fitbit.com/display/API/Rate+Limit

Getting Fitbit's rate limit information to the client application allows the application to better schedule calls to Fitbit's api.

Charlie O'Keefe added 2 commits June 8, 2015 14:39
This is especially useful for the rate limit
headers returned by fitbit's api
https://wiki.fitbit.com/display/API/Rate+Limit

Getting Fitbit's rate limit information to the
client application allows the application to
better schedule calls to Fitbit's api.
@whazzmaster
Copy link
Owner

I like it; I'm going to play with this patch locally for a bit before merging as I want to think about how the http_headers key addition will work out in practice. My initial reaction is that it's a good backwards-compatible step, but I want to be sure.

Thanks for the PR!

@charlieok
Copy link
Author

Great, thanks for taking a look! Looking forward to the day I can delete our local fork 😄

@jamescook
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants