Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Multiset(s) subscriptable with Multiset[_T] syntax #138

Merged
merged 10 commits into from
Aug 27, 2024

Conversation

ldeluigi
Copy link
Contributor

Closes #136.

Tested with the CI.

Copy link
Owner

@wheerd wheerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work on this issue! I have a concern to merge it like this because I'm not sure about the runtime performance impact of this change. Also I'm unable to test myself because I don't have a working computer at the moment 😕

multiset/__init__.py Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 97.436% (+0.02%) from 97.419%
when pulling b98a620 on ldeluigi:master
into 5ae009f on wheerd:master.

Copy link
Owner

@wheerd wheerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@wheerd wheerd merged commit 2b974b2 into wheerd:master Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: type 'FrozenMultiset' is not subscriptable
3 participants