Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for including code files and segments #25

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Support for including code files and segments #25

merged 3 commits into from
Aug 26, 2020

Conversation

astubbs
Copy link
Contributor

@astubbs astubbs commented Aug 26, 2020

No description provided.

@astubbs astubbs mentioned this pull request Aug 26, 2020
Open
@zteater zteater self-requested a review August 26, 2020 14:44
@zteater zteater changed the base branch from master to develop August 26, 2020 14:44
zteater
zteater approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@zteater zteater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for adding this @astubbs

@zteater zteater merged commit c9ee03a into whelk-io:develop Aug 26, 2020
@astubbs
Copy link
Contributor Author

astubbs commented Aug 26, 2020

oh wow, that was quick! Wasn't quite done for the day, also added: #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zteater zteater zteater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astubbs @zteater