Skip to content

Commit

Permalink
dev/streamlit app typing (#846)
Browse files Browse the repository at this point in the history
* Move the `ConnectionManager` impl for stlite to the Streamlit submodule to avoid the circular dependency between it in `@stlite/kernel` and `@streamlit/lib`

* Set up `@stlite/sharing` to run `tsc` at building

* Change `moduleResolution` to `Node` which is necessary to run type checking at the build without explicit \`tsc\`

* Update the streamlit submodule
  • Loading branch information
whitphx committed Apr 28, 2024
1 parent 995d204 commit 404d12e
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 225 deletions.
2 changes: 1 addition & 1 deletion packages/kernel/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export * from "./kernel";
export * from "./streamlit-replacements/lib/ConnectionManager";
export * from "./react-helpers";
export * from "./types";
export * from "./consts";
221 changes: 0 additions & 221 deletions packages/kernel/src/streamlit-replacements/lib/ConnectionManager.ts

This file was deleted.

2 changes: 1 addition & 1 deletion packages/sharing-editor/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "esnext",
"moduleResolution": "Bundler",
"moduleResolution": "Node",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/sharing/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@
"noEmit": true,
"jsx": "react-jsx"
},
"include": ["src"]
"include": ["src", "../../streamlit/frontend/lib/src/**/*.d.ts"]
}
2 changes: 1 addition & 1 deletion streamlit

0 comments on commit 404d12e

Please sign in to comment.