Skip to content

Commit

Permalink
Set moduleResolution as Node because it's necessary to run correc…
Browse files Browse the repository at this point in the history
…t type checking at build time (#850)

* Set `moduleResolution` as `Node` because it's necessary to run correct type checking at build time

* fix typing in nodejs-worker.ts
  • Loading branch information
whitphx committed Apr 4, 2024
1 parent f02c67d commit af3fe3d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/desktop/src/nodejs-worker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export class NodeJsWorkerMock {
constructor() {
this.initializePromise = window.nodeJsWorkerAPI.initialize();

window.nodeJsWorkerAPI.onMessage((data) => {
window.nodeJsWorkerAPI.onMessage((data: unknown) => {
this.onmessage && this.onmessage({ data });
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/desktop/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "esnext",
"moduleResolution": "Bundler",
"moduleResolution": "Node",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/mountable/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "esnext",
"moduleResolution": "Bundler",
"moduleResolution": "Node",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/sharing/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "esnext",
"moduleResolution": "Bundler",
"moduleResolution": "Node",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
Expand Down

0 comments on commit af3fe3d

Please sign in to comment.