-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the build configurations to upgrade Streamlit to v1.17 #471
Comments
This can be solved by setting the - "browserslist": {
- "production": [
- ">0.2%",
- "not dead",
- "not op_mini all"
- ],
- "development": [
- "last 1 chrome version",
- "last 1 firefox version",
- "last 1 safari version"
- ]
- },
+ "browserslist": [
+ ">0.2%",
+ "not dead",
+ "not ie <= 11",
+ "not op_mini all"
+ ], This field controls the Babel transpilation target (it is configured for CRA here), and this change makes the output in dev-mode compatible older browsers by adding It implies that with the current browserslist config, Babel emits such modern syntax without transpiling it, and some successor step in the Webpack build process raises the error as it can't parse it. So, the solutions would be as follow.
|
I found another simple workaround, adding a plugin specific for that syntax, |
When I tried to upgrade the
streamlit
submodule to v1.17 (rebasing the latest branchstlite-1.13.0
to1.17.0
), the build was broken.For example, when running
yarn start
in@stlite/mountable
, the following error occurs.The line this error is pointing to has been introduced at https://github.com/streamlit/streamlit/pull/5913/files#diff-845917f3a07167e741db444532fae1e083d5b9f84ac8e8e38d3a34818a311ad8R242, where the logical assignment operators were started being used. This syntax is at Stage 4 (https://github.com/tc39/proposal-logical-assignment).
The text was updated successfully, but these errors were encountered: