Set browserslist as same as the Streamlit frontend package so that Babel can transpile some modern syntax that will be introduced to the Streamlit codebase #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bel can transpile some modern syntax that will be introduced to the Streamlit codebase such as https://github.com/streamlit/streamlit/pull/5913/files#diff-845917f3a07167e741db444532fae1e083d5b9f84ac8e8e38d3a34818a311ad8R242
whitphx
changed the title
github-actions
bot
temporarily deployed
to
Preview: (fix/browserslist)
|
This PR is incomplete at this point because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of upgrading the
streamlitsubmodule from v1.13.0 to v1.17.0.A modern syntax has been introduced to
streamlit/frontendsince v1.17.0 such as this and it causes an error at Babel transpiling with the current browser compatibility settings on@stlite/mountableand@stlite/desktop.So we upgraded the settings to be same as the one defined at
streamlit/frontend/package.jsonso that it can be transpiled.