Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/shared requirements txt parser #432

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

whitphx
Copy link
Owner

@whitphx whitphx commented Dec 12, 2022

@whitphx
Copy link
Owner Author

whitphx commented Dec 14, 2022

  • Introduce a bundler to embed the code from @stlite/common, which is a private package, into bin/dump_artifacts.js.
  • We selected esbuild as the bundler because it supports everything needed out-of-the-box such as TypeScript it just worked with simple configs.
    • Webpack v4 does not support some necessary features such as handling import.meta.url and does things too much such as injecting their original require implementation which leads to unavailability of require.resolve.
    • Rollup.js does not work well at bundling @stlite/common even if we converted it to be a CommonJS module or introduced node-resolve and commonjs plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create @stlite/common or @stlite/utils package Improve the requirements.txt parser to ignore comment lines
1 participant