Add stlite modifications #672

lukasmasuch · 2024-01-08T14:02:24Z

Related pull request with Streamlit modifications: whitphx/streamlit#7

whitphx

Thank you for the PR!
Let me comment as below at this moment, while I'm gonna check the code more deeply soon.

whitphx · 2024-01-16T09:23:43Z

packages/kernel/src/worker.ts

@@ -281,7 +280,6 @@ async function loadPyodideAndPackages() {
  // The following Python code is based on streamlit.web.cli.main_run().
  self.__streamlitFlagOptions__ = {
    ...streamlitConfig,
-    "browser.gatherUsageStats": false,


Do you think this feature should be enabled?

Good question. From our data side, we are able to handle and distinguish telemetry coming from stlite apps. And in the long-term if stlite gets more integrated as an official Streamlit aspect, we probably want to enable it for all stlite apps. But for this update, I think its fine to leave it disabled as default but in a way that it can be activated if it is explicitly set to true.

See the update code

packages/common-react/tsconfig.json

packages/kernel/py/stlite-server/stlite_server/server.py

whitphx · 2024-01-16T09:50:46Z

packages/kernel/py/stlite-server/stlite_server/upload_file_request_handler.py

-            widget_id = self._require_arg(args, "widgetId")
+            path_args = re.match(UPLOAD_FILE_ROUTE, request.path)
+            session_id = path_args.group('session_id')
+            file_id = path_args.group('file_id')


TODO: Check if session_id and file_id can be obtained from kwargs of this handler?
(Now I'm outside and can't confirm it, but think maybe it's possible)

packages/kernel/py/stlite-server/stlite_server/upload_file_request_handler.py

whitphx · 2024-01-16T09:54:56Z

packages/kernel/src/index.ts

@@ -1,5 +1,4 @@
 export * from "./kernel";
 export * from "./streamlit-replacements/lib/ConnectionManager";
-export * from "./streamlit-replacements/lib/FileUploadClient";


Memo: The patched FileUploadClient has been moved to whitphx/streamlit in whitphx/streamlit#7

Co-authored-by: Yuichiro Tachibana (Tsuchiya) <[email protected]>

…h/stlite into stlite-1.27-additions

whitphx

Thanks, and it LGTM!
I'm gonna merge this PR, and let me add some modifications in #671 after merging.

whitphx · 2024-01-17T05:56:18Z

packages/kernel/src/types.ts

@@ -51,6 +51,7 @@ export interface WorkerInitialData {
  };
  mountedSitePackagesSnapshotFilePath?: string;
  streamlitConfig?: StreamlitConfig;
+  disableProgressToasts?: boolean;


This is not needed here, as the worker doesn't refer to this option?

Oh, yes that makes sense 👍

Thanks, I updated it as a part of changes in #671 after merging this PR. Plz track it and leave any comment 👍

* Copy .nvmrc from [email protected] * Update the streamlit submodule, fix some package resolutions for it, and fix @stlite/kernel for streamlit 1.27.0 * Update @stlite/common-react and mountable * Set webpack version in @stlite/mountable as same as [email protected] * Set the resolved webpack version to avoid an error "The 'compilation' argument must be an instance of Compilation", which is caused by multiple versions of webpack. Ref: https://qiita.com/Hanpen3019/items/e6ae5d29b334bc3d7af3 * Update @stlire/sharing * Update @stlite/desktop * Update Makefile * Remove blob-polyfill * Update Makefile * Update the streamlit submodule * Fix .github/workflows/main.yml * Add streamlit/frontend as a workspace * Add a make rule for the streamlit frontend lib * Update wheel versions * Update the streamlit submodule * Set the immutable's version as same as the locked version of the upstream Streamlit frontend to avoid type errors * Add stlite modifications (#672) * Add stlite modifications * Add back connection manager * Move methods * Some updates * Remove header * More cleanup * More changes * More cleanup * More modifications * Don't update pyiodide * More cleanup * Don't Update pyodide * Don't update pyiodide * More cleanup * More cleanup * Rename of option * Remove new line * Minor cleanup * Fix wrong option name * Minor renaming * Fix typo Co-authored-by: Yuichiro Tachibana (Tsuchiya) <[email protected]> * Update comment Co-authored-by: Yuichiro Tachibana (Tsuchiya) <[email protected]> * Remove paths * Change to put * Update URL * Add gatherUsageStats flag --------- Co-authored-by: Yuichiro Tachibana (Tsuchiya) <[email protected]> * Update the streamlit submodule * Add the PUT type to the HttpRequest interface * Fix the imports in ConnectionManager.ts * Fix upload_file_request_handler.py to refer to `kwargs` of the handler method * Fix stlite_server/upload_file_request_handler.py to catch up with the upstream implementation * Remove `form-data-encoder` from `@stlite/kernel` as it's moved to `@streamlit/lib` in whitphx/streamlit#7 * Fix the mountable option parser to distinguish the toast callback options from the kernel options * Remove ctx.disableToast() and ctx.enableToast() which were introduced in #636 because the `disableProgressToasts` and `disableErrorToasts` options play the same role * Update CHANGELOG.md * Apply Prettier to kernel * Fix stlite-server tests * Fix the CI workflows * Fix format and types in stlite-server * Update main.yml fixing the build jobs to initialize with venv * Add the streamlit lib package to the deps of the kernel make rule * Remove the TS dependency from the kernel module to the build artifact of `@streamlit/lib` * Fix main.yml * Fix .github/workflows/gh-pages.yml * Update the streamlit submodule * Fix the streamlit-proto make rule to call the python-init-dev-only rule * Fix the venv make rule to execute it every time * Update DEVELOPMENT.md * Fix desktop/bin/dump_artifacts.ts not to pin the altair version * Fix CI files * Fix tsconfig * Refresh package.json and yarn.lock * Fix stlite_server/server.py making it look more similar to the original server.py * Fix dump_artifacts.ts * Add a test for the file delete endpoint --------- Co-authored-by: Lukas Masuch <[email protected]>

lukasmasuch added 18 commits January 8, 2024 15:00

Add stlite modifications

d5d22a0

Add back connection manager

8e568aa

Move methods

cd2d3e7

Some updates

a8c2cb6

Remove header

c4109e7

More cleanup

9788a64

More changes

b1874d0

More cleanup

7c76588

More modifications

2cf5a3a

Don't update pyiodide

034cb1f

More cleanup

426bf35

Don't Update pyodide

26d2322

Don't update pyiodide

1dc4814

More cleanup

6c749a1

More cleanup

7bd7814

Rename of option

5a71baf

Remove new line

167ce79

Minor cleanup

3009852

lukasmasuch changed the title ~~[WIP] Add stlite modifications~~ Add stlite modifications Jan 9, 2024

lukasmasuch mentioned this pull request Jan 9, 2024

Add modifications for Streamlit 1.27 support whitphx/streamlit#7

Merged

lukasmasuch added 2 commits January 15, 2024 11:56

Fix wrong option name

744fd8e

Minor renaming

33936c5

whitphx reviewed Jan 16, 2024

View reviewed changes

lukasmasuch and others added 7 commits January 16, 2024 12:58

Fix typo

c1ff261

Co-authored-by: Yuichiro Tachibana (Tsuchiya) <[email protected]>

Update comment

f8d4782

Co-authored-by: Yuichiro Tachibana (Tsuchiya) <[email protected]>

Remove paths

89d986b

Merge branch 'stlite-1.27-additions' of https://github.com/LukasMasuc…

148ba30

…h/stlite into stlite-1.27-additions

Change to put

b6e8ef5

Update URL

1b1bd7e

Add gatherUsageStats flag

899730a

whitphx approved these changes Jan 17, 2024

View reviewed changes

whitphx merged commit 42f3a4a into whitphx:dev/upgrade-streamlit-1.27.0 Jan 17, 2024

whitphx mentioned this pull request Jan 18, 2024

dev/upgrade streamlit 1.27.0 #671

Merged

whitphx mentioned this pull request Jan 20, 2024

Update the Component Gallery sample app #682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add stlite modifications #672

Add stlite modifications #672

lukasmasuch commented Jan 8, 2024 •

edited

Loading

whitphx left a comment

whitphx Jan 16, 2024

lukasmasuch Jan 16, 2024

lukasmasuch Jan 16, 2024

whitphx Jan 17, 2024

whitphx Jan 16, 2024

whitphx Jan 16, 2024

whitphx left a comment

whitphx Jan 17, 2024

lukasmasuch Jan 17, 2024

whitphx Jan 17, 2024

Add stlite modifications #672

Add stlite modifications #672

Conversation

lukasmasuch commented Jan 8, 2024 • edited Loading

whitphx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

whitphx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukasmasuch commented Jan 8, 2024 •

edited

Loading