Dev/remove http patch #689
Merged
+1
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitphx
force-pushed
the
dev/remove-http-patch
branch
from
ba4bf16
to
1d338cb
Compare
lukasmasuch
approved these changes
Feb 6, 2024
packages/common/src/requirements.ts
Outdated
| @@ -0,0 +1,4 @@ | |||
| // stlite-specific requirements | |||
| export const STLITE_REQUIREMENTS = [ | |||
| "urllib3==2.2.0", // `urllib3` supports Pyodide since 2.2.0. https://urllib3.readthedocs.io/en/stable/reference/contrib/emscripten.html | |||
There was a problem hiding this comment.
nit: can we do >=2.2.0 here?
|
Well.. changed my mind; specifying |
This reverts commit 1d338cb.
whitphx
force-pushed
the
dev/remove-http-patch
branch
from
be9713a
to
0df4fdc
Compare
whitphx
force-pushed
the
dev/remove-http-patch
branch
from
0df4fdc
to
4e8bd77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.