Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Coinbase missing API key and secret when starting scanner #839

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

mominafiz
Copy link
Contributor

@mominafiz mominafiz commented Mar 3, 2024

Description

Coinbase Auth API requires an API key and secret to initialize the CoinbaseAuthAPI class. PycryptoBot class' constructor migrates the API key and secret to coinbase.key file and second-time initialization results in a missing key and secret. Instead of adding it to the config.json to be read correctly by the code, read it from coinbase.key file where it is supposed to exit going forward.

Formatting using black added more diff to the file.

Partially fixes #832 (bullet 1)

Type of change

Please make your selection.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires a new dependency
  • Code Maintainability / comments
  • Code Refactoring / future-proofing

How Has This Been Tested?

CLI script execution: python ./scanner.py

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added pytest unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mominafiz mominafiz force-pushed the fix/coinbase-api-key-missing branch from 903fa5c to 53ba720 Compare March 3, 2024 00:25
@mominafiz mominafiz force-pushed the fix/coinbase-api-key-missing branch from 53ba720 to 2cbc020 Compare March 3, 2024 01:18
@whittlem whittlem changed the base branch from main to beta March 4, 2024 10:03
@whittlem whittlem merged commit 828f950 into whittlem:beta Mar 4, 2024
@whittlem
Copy link
Owner

whittlem commented Mar 4, 2024

@mominafiz, thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Coinbase API grabbing Quote Currency
2 participants