Keybindings update for Windows & Linux #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamczewski
force-pushed
the
feature/keybindings-update
branch
from
ef9ea99
to
f405405
Compare
|
Any word from this by the owner? Is this project no longer supported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension keybindings are duplicating the default one provided by VS Code, therefore they are not working correctly on other platforms than Mac. I added not conflicting shortcuts for Windows and Linux.
Note: One thing worth considering is changing both command id's prefix to something more specific.
extension.insertLogStatementcould becomeconsole-utils.insertLogStatement.Possibly it could be breaking change for peoples who already are customising theirs shortcuts.
Related issue: #1