Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import handling #38

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Fix import handling #38

merged 1 commit into from
Aug 12, 2020

Conversation

Stebalien
Copy link
Collaborator

Unfortunately, while goimports works in many cases, it won't always work. This change handles imports internally.

@Stebalien
Fix import handling
f9912a4 
Unfortunately, while goimports works in many cases, it won't always work. This
change handles imports internally.
whyrusleeping
whyrusleeping approved these changes Aug 12, 2020
View reviewed changes
Copy link
Owner

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks slightly better

@whyrusleeping whyrusleeping merged commit 958ddff into whyrusleeping:master Aug 12, 2020
@Stebalien Stebalien deleted the feat/imports branch August 12, 2020 21:36
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @whyrusleeping