Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReleaseCmd add a git tag #157

Open
Stebalien opened this issue Jan 17, 2018 · 3 comments
Open

Make ReleaseCmd add a git tag #157

Stebalien opened this issue Jan 17, 2018 · 3 comments

Comments

@Stebalien
Copy link
Collaborator

Specifically, I'd tag it with:

git tag -a "v$VERSION" -m "gx release published as $HASH"

To do this, we'll need:

  • Access to the hash.
  • The ability to run multiple commands (preferably without bash).
  • Decide on whether or not we want to sign the tags.
  • Changelogs?
@whyrusleeping
Copy link
Owner

Yeah, I really want this. @frrist proposed this back in december I remember.

@dignifiedquire
Copy link

This is even more important now that gomod is a thing, as it strongly relies on git tags for version information.

@anacrolix
Copy link
Contributor

anacrolix commented Dec 17, 2018

Lack of tags requires workarounds to use go.mod. A working example using Go modules requires some specific git revisions to work around missing tags in recent releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants