Add labels for source and target language selectors #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you share a screenshot of this? Unable to test locally 😕 |
Instead of putting a single joining label between the two selectors (which doesn't work in all languages) this gives them their own labels (above). Other layout is adjusted to keep things aligned (e.g. the up- and down-load buttons need to stay aligned with the language selectors). Bug: T216054
samwilson
force-pushed
the
lang-labels-T216054
branch
from
83ef4a1
to
9fc36e0
Compare
|
It's currently looking like this:
|
|
I didn't mean to delete the branch. Although I'm not sure if this is still valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of putting a single joining label between the two
selectors (which doesn't work in all languages) this gives them
their own labels (above). Other layout is adjusted to keep things
aligned (e.g. the up- and down-load buttons need to stay aligned
with the language selectors).
Bug: T216054