Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error implement std::io::Error and remove associated Agent's Error type #15

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

wiktor-k
Copy link
Owner

No description provided.

@wiktor-k
Copy link
Owner Author

I'm wondering what do you think about it @baloo?

I'm on the edge to completely remove AgentError and just stick std::io::Error in there. The exact error is irrelevant anyway since it's swallowed by tokio::spawn and IO Error has some facilities for storing "foreign" errors via Other variant 🤔

@baloo
Copy link
Collaborator

baloo commented Feb 22, 2024

I might want to revisit error in #16. I don't know yet. Can we hold off on this?

@wiktor-k
Copy link
Owner Author

I might want to revisit error in #16. I don't know yet. Can we hold off on this?

As far as I know we don't have any deadlines here 😏 😉

@wiktor-k
Copy link
Owner Author

BTW thanks for all your contributions. This crate was in dire need of maintenance but I just never had time to do it properly. Thanks! 🙏

Split Agent and Session for per-session use-cases
Copy link
Collaborator

@baloo baloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can use the content of #17 and we can always revisit this PR later

@wiktor-k
Copy link
Owner Author

Okay, thanks! I was just looking at how to merge #17 back without this but didn't get anywhere :)

@wiktor-k wiktor-k merged commit 2f84bdf into main Feb 23, 2024
9 checks passed
@wiktor-k wiktor-k deleted the wiktor/error-fixes branch February 23, 2024 08:06
@wiktor-k
Copy link
Owner Author

I've also checked #16 and I think it won't be that hard to rebase... the only thing is adding Display match arms to new errors but it should be mostly straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants